Skip to content

[6/16] feat: add variable jumps and landing poses - #123

Merged
arudaev merged 5 commits into
feature/27-walk-and-runfrom
feature/28-controlled-jump
Oct 24, 2026
Merged

arudaev merged 5 commits into
feature/27-walk-and-runfrom
feature/28-controlled-jump

Conversation

@Vatsal2005

@Vatsal2005 Vatsal2005 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Space/K and gamepad A/Cross now jump with a 52px minimum tap rise, about 96px held rise, 0.1s coyote time and a 0.12s input buffer. The supplied landing drawing plays on contact; drops of at least two body heights select the four-frame hard landing at 12fps. Sprites are never scaled for squash. F2 keeps the measured apex height visible after landing.

Issue

Closes #28

Stack

Base: feature/27-walk-and-run. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.

Acceptance criteria

  • Variable tap/hold height, approximately 52px and 96px
  • 0.1s coyote time and 0.12s jump buffer
  • Landing pose and four-frame hard landing are selected from the supplied atlas

Verification

  • Node 22: npm run typecheck, npm test (66 tests), npm run build; includes main integration at e8577ab
  • py -3.13 scripts/check_docs.py
  • git diff --cached --check
  • Tests simulate complete tap/held/intermediate arcs, late coyote rejection, buffer expiry, no repeated jump from holding, and normal/hard landing selection
  • Browser: Space tap measured 51.2px, K hold measured 96.1px, landed back on Garden floor without drift or console errors
  • Every Creek deck, coyote and buffering in the route: complete after [M1-S3] Walk up hills and slide down steep slopes #29/[M1-S4] Drop through one-way platforms and climb ladders #30 provide slopes, one-way platforms and ladders
  • Physical gamepad and Vercel preview: Vatsal2005 needs project access to create Vercel deployments

Screenshots

Measured heights shown in chat and saved in ignored tmp/verification/28-tap.png and 28-held.png. Full animation switching follows in #31; high-fall threshold 152px is a tuning constant for route playtests.

Give jump presses a short coyote window and input buffer, and tune tap and held rises to the documented stage scale. Track apex height in the debug display so the result can be measured during play.

Use the authored landing poses at contact, with a four-frame hard landing for drops of two body heights. Keep sprite dimensions fixed.
@Vatsal2005 Vatsal2005 self-assigned this Oct 23, 2026
@Vatsal2005
Vatsal2005 requested a review from arudaev October 23, 2026 21:45
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
wincs Error Error Oct 24, 2026 12:29am UTC

Request Review

@github-actions github-actions Bot added the area:player Hero movement, animation state, camera label Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/6] feat: add variable jumps and landing poses [6/7] feat: add variable jumps and landing poses Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/7] feat: add variable jumps and landing poses [6/8] feat: add variable jumps and landing poses Oct 23, 2026
Carry the reviewed lane B foundation and latest human-merged integration upward without rewriting published history.
@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy.
- Click here to add @Vatsal2005 to the team.
- If you initiated this build, request access.
- If you're already a member of the arudaev's projects team, make sure that your Vercel account is connected to your GitHub account.

Learn more about collaboration on Vercel and other options here.

@arudaev
arudaev added this pull request to stack #129 October 23, 2026 22:12
@Vatsal2005 Vatsal2005 changed the title [6/8] feat: add variable jumps and landing poses [6/9] feat: add variable jumps and landing poses Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/9] feat: add variable jumps and landing poses [6/10] feat: add variable jumps and landing poses Oct 23, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@Vatsal2005 Vatsal2005 changed the title [6/10] feat: add variable jumps and landing poses [6/11] feat: add variable jumps and landing poses Oct 23, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@Vatsal2005 Vatsal2005 changed the title [6/11] feat: add variable jumps and landing poses [6/12] feat: add variable jumps and landing poses Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/12] feat: add variable jumps and landing poses [6/13] feat: add variable jumps and landing poses Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/13] feat: add variable jumps and landing poses [6/14] feat: add variable jumps and landing poses Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [6/14] feat: add variable jumps and landing poses [6/15] feat: add variable jumps and landing poses Oct 24, 2026
@Vatsal2005 Vatsal2005 changed the title [6/15] feat: add variable jumps and landing poses [6/16] feat: add variable jumps and landing poses Oct 24, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@arudaev
arudaev marked this pull request as ready for review October 24, 2026 01:34
@arudaev
arudaev merged commit 2cb1f6d into main Oct 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:player Hero movement, animation state, camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M1-S2] Jump with control

2 participants