Repository navigation
[7/16] feat: follow ground slopes and slide downhill - #125
Merged
Merged
Conversation
Interpolate the authored ground and carry contact across slope joins, including transitions back to flat ground. The previous slope sets the contact tolerance so a downhill-to-flat join cannot introduce a one-frame fall. Slide downhill above 40 degrees, retain jump control and use the authored fall poses. Test both movement speeds against the real Creek segments and steep fixture slopes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
This was referenced Oct 23, 2026
Carry the reviewed lane B foundation and latest human-merged integration upward without rewriting published history.
The real first Creek seam rises five pixels. Permit a six-pixel endpoint tolerance only when a grounded body crosses a polyline endpoint, so it reaches the neighboring floor instead of falling through it. Exercise both actual seams in both states, both directions and at walk and run speeds.
9 of 11 tasks
9 of 10 tasks
Carry human-merged lane A changes upward without rewriting published commits.
11 of 13 tasks
9 of 10 tasks
Carry human-merged lane A changes upward without rewriting published commits.
7 of 8 tasks
7 of 11 tasks
9 of 12 tasks
10 of 12 tasks
Carry human-merged lane A changes upward without rewriting published commits.
arudaev
marked this pull request as ready for review
October 24, 2026 01:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Ground contacts now interpolate the authored polylines instead of treating each segment as flat. Walkable slopes through 40 degrees keep feet attached across uphill, crest, downhill and flat joins; steeper contacts accelerate downhill and allow jumping away. Slide visuals use the supplied stepped fall poses without scaling the sprite.
Issue
Closes #29
Stack
Base:
feature/28-controlled-jump. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.Acceptance criteria
Verification
npm run typecheck,npm test(71 tests),npm run build; includes main integration at e8577abpy -3.13 scripts/check_docs.pygit diff --cached --checkSeam contact
The actual first seam rises from y=461 to y=456. A six-pixel endpoint tolerance applies only when a grounded body crosses a polyline endpoint. Real-file tests cover both seams, states, directions and movement speeds; falling bodies never snap upward.
Screenshots
F2 overlay evidence is in #120 and movement screenshots in #122. The current authored Creek data has no brown slide segments; steep-slide behavior is exercised by geometry fixtures in the tests. Full animation switching follows in #31.