Skip to content

[8/16] feat: add one-way decks and ladder climbing - #126

Merged
arudaev merged 6 commits into
feature/29-slopesfrom
feature/30-platforms-and-ladders
Oct 24, 2026
Merged

arudaev merged 6 commits into
feature/29-slopesfrom
feature/30-platforms-and-ladders

Conversation

@Vatsal2005

@Vatsal2005 Vatsal2005 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Yellow one-way decks catch falling feet and let rising jumps pass through. Down + Jump drops through the support. Up/down enters authored climb zones at 70px/s; release holds position, sideways input or Jump leaves, and Player.canAttack is false while attached. Ladder ends align with nearby authored deck heights, including the small annotation offsets. Reserved ledges remain inactive.

Issue

Closes #30

Stack

Base: feature/29-slopes. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.

Acceptance criteria

  • Stand on yellow lines, jump up through, drop with Down + Jump
  • Slow climbing in blue zones; hold on release; attacking disabled through the controller's canAttack contract
  • No ledge pull-up

Verification

  • Node 22: npm run typecheck, npm test (77 tests), npm run build; includes main integration at e8577ab
  • py -3.13 scripts/check_docs.py
  • git diff --cached --check
  • Tests cover rising/falling one-way contacts, drop-through onto solid ground, climb/hold/exit, input ordering, reserved ledges, and every real Creek climb zone in both directions
  • Browser: first ladder reaches y=363 deck, tall ladder holds when released and reaches y=126; Down + Jump falls to y=508 and selects hard landing; no console errors
  • Browser traversal of every ladder/deck: continue with camera follow [M1-S5] Camera follows with parallax layers #32
  • Physical gamepad and Vercel preview: Vatsal2005 requires project access on Vercel

Screenshots

Shown in chat, saved in ignored tmp/verification/30-ladder-top.png, 30-climb.png and 30-drop.png. The hard-landing readout after the tall drop also exercises #28's landing selection on the authored route.

Use yellow polylines as one-way supports and let Down plus Jump drop through. Align slow climbing with authored blue zones and their nearby deck heights, hold on release and expose the attack lock while climbing.

Handle Down arriving before Jump at a ladder top and prevent immediate ladder grabs after detaching. Exercise every real Creek climb zone and the input-order regression in tests.
@Vatsal2005 Vatsal2005 self-assigned this Oct 23, 2026
@Vatsal2005
Vatsal2005 requested a review from arudaev October 23, 2026 21:58
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
wincs Error Error Oct 24, 2026 12:30am UTC

Request Review

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy.
- Click here to add @Vatsal2005 to the team.
- If you initiated this build, request access.
- If you're already a member of the arudaev's projects team, make sure that your Vercel account is connected to your GitHub account.

Learn more about collaboration on Vercel and other options here.

Carry the reviewed lane B foundation and latest human-merged integration upward without rewriting published history.
@arudaev
arudaev added this pull request to stack #129 October 23, 2026 22:12
Carry the verified endpoint tolerance and real seam regression test up from the slope branch without rebasing.
@Vatsal2005 Vatsal2005 changed the title [8/8] feat: add one-way decks and ladder climbing [8/9] feat: add one-way decks and ladder climbing Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [8/9] feat: add one-way decks and ladder climbing [8/10] feat: add one-way decks and ladder climbing Oct 23, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@Vatsal2005 Vatsal2005 changed the title [8/10] feat: add one-way decks and ladder climbing [8/11] feat: add one-way decks and ladder climbing Oct 23, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@Vatsal2005 Vatsal2005 changed the title [8/11] feat: add one-way decks and ladder climbing [8/12] feat: add one-way decks and ladder climbing Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [8/12] feat: add one-way decks and ladder climbing [8/13] feat: add one-way decks and ladder climbing Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [8/13] feat: add one-way decks and ladder climbing [8/14] feat: add one-way decks and ladder climbing Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [8/14] feat: add one-way decks and ladder climbing [8/15] feat: add one-way decks and ladder climbing Oct 24, 2026
@Vatsal2005 Vatsal2005 changed the title [8/15] feat: add one-way decks and ladder climbing [8/16] feat: add one-way decks and ladder climbing Oct 24, 2026
Carry human-merged lane A changes upward without rewriting published commits.
@arudaev
arudaev marked this pull request as ready for review October 24, 2026 01:34
@arudaev
arudaev merged commit 2cb1f6d into main Oct 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:player Hero movement, animation state, camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M1-S4] Drop through one-way platforms and climb ladders

2 participants