Skip to content

[15/16] feat: add up attacks and pogo slams - #146

Merged
arudaev merged 2 commits into
feature/45-rover-controllerfrom
feature/40-overhead-and-pogo
Oct 24, 2026
Merged

arudaev merged 2 commits into
feature/45-rover-controllerfrom
feature/40-overhead-and-pogo

Conversation

@Vatsal2005

@Vatsal2005 Vatsal2005 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Up plus Act now selects the six-pose overhead attack, with contact only on poses 02/03. Airborne Down plus Act winds up, descends with the chair and bounces off a living enemy or hazard using the full jump impulse. A swept tip probe prevents thin-target tunnelling. Pogo recovery buffers one directional press; plain-floor landing, damage and death clear it.

Special input takes priority over climbing and coffee. Accepted hits retain the existing spark, sound and 60ms stop; enemy contact resolves after the chair so a pogo can snap to the target top before body damage. Defeated wrecks are excluded. Plain floors play the remaining slam poses without adding a crack or shockwave.

Issue

Closes #40
Refs #45, #46

Stack

Base: feature/45-rover-controller. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.

Acceptance and remaining playthrough

  • Up + Act selects up attack
  • Airborne Down + Act slams; enemy and hazard contacts produce pogo
  • Tests perform three fresh pogos against the three-health rover model and strike a 40px crab fixture through its authored one-way deck
  • Browser: four successive slam hits and bounces on the stationary rover fixture, one initial Jump press and five cells retained; the explicit slam 4 counter distinguishes these from sweeps
  • Full moving tutorial rover clear and actual crab through-deck playthrough when [M2-S7] Crab: creep, rear, stab #46 is integrated. The moving-rover attempt did not clear and is not reported as complete
  • Browser hazard fixture, physical gamepad and Vercel preview

Verification

  • Node 22: npm run typecheck, npm test (119 tests), npm run build; includes main integration at e8577ab
  • py -3.13 scripts/check_docs.py
  • git diff --cached --check
  • Unit coverage: actual clip metadata, exact contact bounds in both directions, active pose windows, one strike per target, three rover pogos, full 95–97px bounce without Jump held, thin hazards, rising rejection, wreck exclusion, armour bounce, input buffer/cancellation and plain-floor recovery
  • Browser Up + Act beside the real coffee machine renders up-04 while feet stay grounded; the four-pogo fixture shows pogo-00 and hits 4 | slam 4. No console errors
  • Existing Vercel deployments require Vatsal2005 to be granted project access by the owner

Reference comparison

Plan and mask measurements: docs/02 overhead attacks.

Native overhead, slam and pogo poses on one foot baseline

Reproduce: python scripts/compare.py lineup chair-overhead:up-02 chair-overhead:up-03 chair-overhead:slam-03 chair-overhead:slam-04 chair-overhead:pogo-00 chair-overhead:pogo-02 --out game/verification/40-overhead-pose-compare.png.

The atlas cell is 108×126 with foot pivot 54,126. Dark chair-leg pixels in up-03 occupy x51–78/y12–37: the contact envelope is x−3…24 and 89…114px above the feet. Slam-03 lower legs span x65–91, giving 11…37px forward. The downward probe sweeps previous/current feet with a two-pixel grain margin. Runtime preserves native pose sizes; the ruler is 13px/foot. The chair extends beyond the 76px body in overhead poses.

Browser evidence shown in chat and saved in ignored tmp/verification/40-counted-pogos.png and 40-up-at-coffee.png. The live repeated-pogo check uses the pre-existing stationary combat-test fixture, not a completed moving-rover clear. No art or collision annotations changed.

Measure chair-overhead contacts from the approved atlas. Add directional Act priority, a swept downward probe, full-height pogo impulse and a one-input buffer through descent and bounce recovery.

Resolve chair contact before enemy damage and hazard reset. Exclude wrecks, cancel queued moves on damage or floor landing, and retain the existing light impact effects. Typecheck, 119 tests, build and docs pass; browser confirms four fixture pogos and the up pose beside coffee.
@vercel

vercel Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
wincs Error Error Oct 24, 2026 12:34am UTC

Request Review

@Vatsal2005 Vatsal2005 self-assigned this Oct 24, 2026
@Vatsal2005
Vatsal2005 requested a review from arudaev October 24, 2026 00:05
@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown

@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy.
- Click here to add @Vatsal2005 to the team.
- If you initiated this build, request access.
- If you're already a member of the arudaev's projects team, make sure that your Vercel account is connected to your GitHub account.

Learn more about collaboration on Vercel and other options here.

Carry human-merged lane A changes upward without rewriting published commits.
@arudaev
arudaev added this pull request to stack #129 October 24, 2026 00:39
@arudaev
arudaev marked this pull request as ready for review October 24, 2026 01:34
@arudaev
arudaev merged commit 2cb1f6d into main Oct 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:combat Chair, guard, health, damage, save points, pickups area:docs Design docs, README, contributor guides area:enemies Autonomous robots and Jenny area:player Hero movement, animation state, camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M2-S2] Up attack and down slam with a pogo bounce

2 participants