Skip to content

[2/16] ci: check the game with node 22 on pull requests - #111

Merged
arudaev merged 11 commits into
mainfrom
ci/25-game-checks
Oct 24, 2026
Merged

arudaev merged 11 commits into
mainfrom
ci/25-game-checks

Conversation

@Vatsal2005

@Vatsal2005 Vatsal2005 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Run the game checks on Node 22 for pull requests touching game/ or this workflow, and for matching pushes to main. A failed install, typecheck, test or build stops the job. npm cache uses the game lockfile. Documents and Art pipeline workflows are unchanged.

Issue

Closes #25

Stack

Base: main. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.

Acceptance criteria

  • Game workflow runs npm ci, typecheck, tests and build for game PRs
  • Documents and Art pipeline workflows remain unchanged

Verification

  • py -3.13 scripts/check_docs.py — 590 files
  • Node 22: npm run typecheck, npm test (39 tests), npm run build; includes main integration at e8577ab
  • git diff --cached --check
  • Deliberate type error failed with TS2322: run 40021287225. Removing the probe restored green: run 40021434148. The probe is absent from the final diff.
  • Final Game check: npm ci, typecheck, tests and build all pass on Node 22

Screenshots

No visible game change. CI run links will record the red/green probe. Scaffold browser verification is in #94; Vercel deployment remains lane A's #23.

Run clean installation, type checking, tests and the production build for game changes and the workflow itself. Keep the independent document and art workflows unchanged.
@Vatsal2005 Vatsal2005 self-assigned this Oct 23, 2026
@Vatsal2005
Vatsal2005 requested a review from arudaev October 23, 2026 20:41
@github-actions github-actions Bot added the area:delivery Build, Vercel, CI, workflows, the board label Oct 23, 2026
Exercise the negative verification required by issue 25 on this draft PR. This temporary probe must make the Game typecheck step fail; remove it after recording the run.
The Game workflow rejected the deliberate type error with TS2322 in run 40021287225. Restore the clean source so the same pipeline can verify the green path.
@Vatsal2005
Vatsal2005 marked this pull request as ready for review October 23, 2026 20:45
Bring in the human-merged scaffold, converter, enemy atlases and Rusty Creek collision before continuing the dependent stack.
@Vatsal2005
Vatsal2005 changed the base branch from chore/22-scaffold to main October 23, 2026 20:51
Include the human-merged stage exporter, layer split and Hidden Garden collision before validating the next runtime branch.
@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy.
- Click here to add @Vatsal2005 to the team.
- If you initiated this build, request access.
- If you're already a member of the arudaev's projects team, make sure that your Vercel account is connected to your GitHub account.

Learn more about collaboration on Vercel and other options here.

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
wincs Error Error Oct 24, 2026 12:27am UTC

Request Review

Include the human-merged stage build hook and registered story and UI scenes before continuing runtime validation.
The merged prebuild hook now exports stage assets using the standard-library Python tool. Provide Python 3.13 explicitly so Game CI checks the same generated build as local development.
@Vatsal2005 Vatsal2005 changed the title [2/4] ci: check the game with node 22 on pull requests [2/5] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/5] ci: check the game with node 22 on pull requests [2/6] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/6] ci: check the game with node 22 on pull requests [2/7] ci: check the game with node 22 on pull requests Oct 23, 2026
Bring in human-merged lane A integration while preserving the published stack history.
@Vatsal2005 Vatsal2005 changed the title [2/7] ci: check the game with node 22 on pull requests [2/8] ci: check the game with node 22 on pull requests Oct 23, 2026
@arudaev
arudaev added this pull request to stack #129 October 23, 2026 22:12
@Vatsal2005 Vatsal2005 changed the title [2/8] ci: check the game with node 22 on pull requests [2/9] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/9] ci: check the game with node 22 on pull requests [2/10] ci: check the game with node 22 on pull requests Oct 23, 2026
Keep this branch current with main while preserving published history.
@Vatsal2005 Vatsal2005 changed the title [2/10] ci: check the game with node 22 on pull requests [2/11] ci: check the game with node 22 on pull requests Oct 23, 2026
Keep this branch current with main while preserving published history.
@Vatsal2005 Vatsal2005 changed the title [2/11] ci: check the game with node 22 on pull requests [2/12] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/12] ci: check the game with node 22 on pull requests [2/13] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/13] ci: check the game with node 22 on pull requests [2/14] ci: check the game with node 22 on pull requests Oct 23, 2026
@Vatsal2005 Vatsal2005 changed the title [2/14] ci: check the game with node 22 on pull requests [2/15] ci: check the game with node 22 on pull requests Oct 24, 2026
@Vatsal2005 Vatsal2005 changed the title [2/15] ci: check the game with node 22 on pull requests [2/16] ci: check the game with node 22 on pull requests Oct 24, 2026
Keep this branch current with main while preserving published history.
@arudaev
arudaev merged commit 2cb1f6d into main Oct 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:delivery Build, Vercel, CI, workflows, the board

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M0-S3] CI: typecheck and build the game on every PR

2 participants