Repository navigation
[2/16] ci: check the game with node 22 on pull requests - #111
Merged
Merged
Conversation
Run clean installation, type checking, tests and the production build for game changes and the workflow itself. Keep the independent document and art workflows unchanged.
13 of 14 tasks
Exercise the negative verification required by issue 25 on this draft PR. This temporary probe must make the Game typecheck step fail; remove it after recording the run.
The Game workflow rejected the deliberate type error with TS2322 in run 40021287225. Restore the clean source so the same pipeline can verify the green path.
Vatsal2005
marked this pull request as ready for review
October 23, 2026 20:45
Bring in the human-merged scaffold, converter, enemy atlases and Rusty Creek collision before continuing the dependent stack.
Include the human-merged stage exporter, layer split and Hidden Garden collision before validating the next runtime branch.
|
@Vatsal2005 must be a member of the arudaev's projects team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
10 of 11 tasks
Include the human-merged stage build hook and registered story and UI scenes before continuing runtime validation.
The merged prebuild hook now exports stage assets using the standard-library Python tool. Provide Python 3.13 explicitly so Game CI checks the same generated build as local development.
This was referenced Oct 23, 2026
8 of 10 tasks
8 of 10 tasks
8 of 10 tasks
Bring in human-merged lane A integration while preserving the published stack history.
9 of 11 tasks
9 of 10 tasks
Keep this branch current with main while preserving published history.
11 of 13 tasks
9 of 10 tasks
Keep this branch current with main while preserving published history.
7 of 8 tasks
7 of 11 tasks
9 of 12 tasks
10 of 12 tasks
Keep this branch current with main while preserving published history.
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Run the game checks on Node 22 for pull requests touching
game/or this workflow, and for matching pushes to main. A failed install, typecheck, test or build stops the job. npm cache uses the game lockfile. Documents and Art pipeline workflows are unchanged.Issue
Closes #25
Stack
Base:
main. Human merges bottom up; retarget the next PR to main and merge origin/main into every open branch, never rebase.Acceptance criteria
Verification
py -3.13 scripts/check_docs.py— 590 filesnpm run typecheck,npm test(39 tests),npm run build; includes main integration at e8577abgit diff --cached --checkScreenshots
No visible game change. CI run links will record the red/green probe. Scaffold browser verification is in #94; Vercel deployment remains lane A's #23.