Skip to content

Fix performance baseline contracts #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wallstop merged 1 commit into from
Oct 14, 2026
Merged

Fix performance baseline contracts #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions Tests/Editor/PerfBaseline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,14 +950,18 @@ internal RunState(string outputDirectory)

private enum Phase
{
Idle,
WaitingColdReady,
InteractionSamples,
WaitingSearchResults,
WarmOpen,
WaitingWarmReady,
BetweenWarmRepetitions,
Finished,
[Obsolete("Please use a valid value")]
None = 0,

// RunState explicitly initializes Idle; phases are never persisted.
Idle = 8,
WaitingColdReady = 1,
InteractionSamples = 2,
WaitingSearchResults = 3,
WarmOpen = 4,
WaitingWarmReady = 5,
BetweenWarmRepetitions = 6,
Finished = 7,
}
}
}
15 changes: 9 additions & 6 deletions Tests/Editor/PerfBaselineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,16 @@ public void ShouldEscapeJsonStrings(string input, string expected)
Assert.AreEqual(expected, PerfBaseline.JsonEscape(input));
}

[Test]
public void ShouldNameFixturesDeterministically()
[TestCase(0, "Player Save")]
[TestCase(7, "Damage Table")]
[TestCase(8, "Player Save 000001")]
[TestCase(9, "World Settings 000001")]
[TestCase(15, "Damage Table 000001")]
[TestCase(16, "Player Save 000002")]
[TestCase(9999, "Damage Table 001249")]
public void ShouldNameFixturesDeterministically(int index, string expected)
{
Assert.AreEqual("Player Save", PerfBaseline.FixtureName(0));
Assert.AreEqual("Damage Table", PerfBaseline.FixtureName(7));
Assert.AreEqual("Player Save 000001", PerfBaseline.FixtureName(8));
Assert.AreEqual("World Settings 000002", PerfBaseline.FixtureName(9));
Assert.AreEqual(expected, PerfBaseline.FixtureName(index));
}

[Test]
Expand Down
Loading