Repository navigation
Fix performance baseline contracts - #242
Merged
Merged
Conversation
The full EditMode gate fails because the baseline driver uses a valid zero phase and one test expects a per-item suffix instead of the fixture cycle. Reserve an obsolete zero sentinel, move the explicitly initialized Idle state to 8, retain other ordinals, and test cycle boundaries through index 9999. These phases are not serialized. Reproduced both failures on Unity 6000.5.2f1, Windows. After repair: focused baseline 23/23, enum 1/1, full EditMode 390/390, PlayMode 15/15. CSharpier, fast check, full local gate and npm pack dry run pass. The gate selects affected surfaces and skips unchanged harness and payload checks. No 10k timing claim is made. Fixes #240. Refs #114, #226.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Two performance-baseline contracts fail the full EditMode suite.
What:
Fixes #240. Refs #114, #226.
Type of Change
Checklist
Note
Low Risk
Test and internal enum contract fixes in the perf baseline driver; no production editor/runtime behavior changes.
Overview
Fixes two PerfBaseline contract mismatches that were failing EditMode tests.
The
Phaseenum now reserves 0 as an obsoleteNonevalue and assignsIdle = 8, while keeping the other phase values at 1–7.RunStatestill starts inIdleexplicitly, so the driver no longer treats the default enum value 0 as idle.ShouldNameFixturesDeterministicallyis expanded into parameterized cases (including cycle boundaries and index 9999). The expectation for index 9 is corrected toWorld Settings 000001, matchingFixtureName’s cycle suffix rules.Reviewed by Cursor Bugbot for commit 2c1480a. Bugbot is set up for automated code reviews on this repo. Configure here.