Repository navigation
date: expand GNU-compatible parsing and formatting - #15111
Conversation
Merging this PR will degrade performance by 12.56%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | file_custom_format |
30 ms | 36.5 ms | -17.9% |
| ❌ | Simulation | file_iso_dates |
31.5 ms | 38.2 ms | -17.52% |
| ❌ | Simulation | file_localized_names |
41.9 ms | 48.6 ms | -13.73% |
| ❌ | Simulation | file_tz_abbreviations |
35.4 ms | 38.1 ms | -7.07% |
| ❌ |
Simulation | complex_relative_date |
292.6 µs | 310.8 µs | -5.84% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing anastygnome:test-util (a197690) with main (e6eb5ad)2
Footnotes
-
444 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(09a1ec1) during the generation of this report, so e6eb5ad was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
ce6b516 to
2e6eecf
Compare
|
extra work => additional cost. |
|
GNU testsuite comparison: |
|
CICD and Android are related to tail/cp, nothing related to this PR |
|
sorry, but we can't take this: |
|
@sylvestre would making the non debug tests into one PR be ok? |
|
just the tests or tests+fixes? |
|
I mean the code & test that fix tests/date/date & date/date-tz are very similar (I blieve matching debug output isn"t really wise but I had matched it to see if we could and discuss it here |
|
Sure but this pr is huge. I would prefer smaller changes |
ef60759 to
d6ed595
Compare
|
I reduced the scope @sylvestre |
|
@cakebaker @xtqqczze if one od you may review this it'd be appreciated |
cakebaker
left a comment
There was a problem hiding this comment.
I'll likely wrap up the review tomorrow. The tests look fine.
|
No issues, take your time, I'll wait
|
9f16f34 to
7f38b54
Compare
7f38b54 to
0a19195
Compare
0a19195 to
c4a35b1
Compare
|
@sylvestre can we merge this as is? |
c4a35b1 to
a197690
Compare
Kudos and thanks! |
|
@cakebaker I have fixed 3 other issues as a spin-off PR, incoming tonight |
@cakebaker #14705 needs updating |
|
@xtqqczze done, thanks for the hint! |
|
Closes #13818? |
|
So many things I can't keep up with |
|
Well done, I think that may be a record for number of issues closed with one PR! |
|
I think this also changed $ TZ=UTC LC_ALL=C date -d 0001-01-01 +%-F
1-01-01After the merge, main prints |
|
@SichenLiang will address this in my current PR. Regression introduced by a lacking coverage |
Handle extended years, epoch seconds, normalization, DST gaps, and strftime modifier precedence
Refs #14705
Closed or superseeds :
Closes #14648
Closes #14649
Closes #9253
Closes #12954
Closes #12944
Closes #12034
Closes #12897
Closes #11657
Closes #11658
Closes #9275
Closes #11752
Closes #14179
Closes #11778
Closes #12064
Unit test ignore removed (may need a backport):
Refs uutils/parse_datetime#279
Refs uutils/parse_datetime#280