Repository navigation
Conversation
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix/date-iso8601-12hour-time-9253
branch
2 times, most recently
from
January 3, 2026 00:29
49d348f to
ad73e7a
Compare
naoNao89
force-pushed
the
fix/date-iso8601-12hour-time-9253
branch
from
February 18, 2026 14:26
ad73e7a to
4c825bf
Compare
The parse_datetime crate's combined parser only accepts 24-hour time. When parsing "YYYY-MM-DD HH:MMam/pm", it fails because the ISO time parser doesn't support meridiem indicators. Normalize by converting dashes to slashes (YYYY-MM-DD → YYYY/MM/DD) which forces separate parsing where 12-hour time is supported. Implementation uses zero-allocation string slicing for efficiency. Fixes uutils#9253
naoNao89
force-pushed
the
fix/date-iso8601-12hour-time-9253
branch
from
February 18, 2026 14:32
4c825bf to
a3966a9
Compare
|
GNU testsuite comparison: |
Add comprehensive tests for issue uutils#9253 to verify ISO-8601 date formats combined with 12-hour time (am/pm) parsing: - Basic am/pm with ISO-8601 dates (YYYY-MM-DD) - Time with seconds - Case variations (am/AM, pm/PM) - a.m./p.m. format - Various hour values (1:30am, 11:59pm) - Edge cases (noon, midnight, single digit hours) - Non-ISO-8601 dates to ensure they still work
HackingRepo
suggested changes
Jun 17, 2026
HackingRepo
left a comment
HackingRepo
left a comment
Contributor
There was a problem hiding this comment.
Hi, @naoNao89
Add -f and -s tests also to see is also applied to them, because i see many prs got merged, of the military prefix j, added only on -d but not on -f or -s, so for not that happens, add a test for -f and -s to see is accepts AM or PM prefix and resolve the conflict.
Contributor
|
the CI has been failing on this one for a while and it hasn't been updated since, so i guess you moved on. closing, but feel free to reopen if you get back to it, thanks |
Collaborator
@anastygnome Presumably #9253 was fully resolved by #15111, so there should be no need to reopen this PR, right? |
Contributor
|
It's part of what I'll push tonight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes parsing of ISO-8601 dates with 12-hour time (e.g.,
2025-01-01 12:00am).The
parse_datetimecrate's combined parser only accepts 24-hour format. Workaround converts dash-separated dates to slashes when 12-hour time is detected, forcing separate parsing where am/pm is supported.Fixes #9253