Fix some more issues with date by anastygnome · Pull Request #15286 · uutils/coreutils

anastygnome · 2026-10-12T17:56:25Z

Closes #14681

Closes #12943
Closes #14674
Closes #14679
Closes #14781
Closes #14791

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

anastygnome · 2026-10-12T19:42:08Z

@xtqqczze but wait
There's MORE!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codspeed · 2026-10-13T14:07:35Z

Merging this PR will degrade performance by 3.45%

⚠️

2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

single_date_now

complex_relative_date

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 11 untouched benchmarks
⏩ 460 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌ ⚠️	Simulation	`single_date_now`	179.5 µs	185.9 µs	-3.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing anastygnome:test-util (96328d7) with main (1747ba1)}

460 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

anastygnome · 2026-10-13T14:11:10Z

Merging this PR will degrade performance by 3.66%

179.7 µs 186.5 µs -3.66%

Hmm @sylvestre, maybe this is too sensitive.

anastygnome · 2026-10-13T15:01:39Z

@SichenLiang Added a commit to fix the regression you spotted with %F

Copilot

🟡 Changes recommended

Short-option normalization corrupts attached values, and day-month dates are omitted from weekday normalization.

2 open findings

🧠 Review effort: Balanced

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

SichenLiang · 2026-10-13T16:50:05Z

Thanks! checked 60df587, and the cases we reported now match GNU, including %-F, %_F and widths such as %6F.

I found one case that went back to the behavior from before #15111:

$ TZ=UTC LC_ALL=C date -d 2024-06-15 +%+6F

GNU 9.12 and current main print 2024-06-15, while this PR prints +2024-06-15. I also checked %+12F; that one matches GNU.

xtqqczze · 2026-10-13T17:01:45Z

Merging this PR will degrade performance by 3.66%

179.7 µs 186.5 µs -3.66%

The performance regression is consistent, but it's not a blocker.

xtqqczze · 2026-10-13T17:06:37Z

@anastygnome I'm obliged to ask: does this fix any open issues or supersede any PRs? Also, is it ready for review?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

anastygnome · 2026-10-13T17:12:17Z

Thanks! checked 60df587, and the cases we reported now match GNU, including %-F, %_F and widths such as %6F.

I found one case that went back to the behavior from before #15111:
$ TZ=UTC LC_ALL=C date -d 2024-06-15 +%+6F
GNU 9.12 and current main print 2024-06-15, while this PR prints +2024-06-15. I also checked %+12F; that one matches GNU.

fixed

anastygnome · 2026-10-13T17:13:07Z

@anastygnome I'm obliged to ask: does this fix any open issues or supersede any PRs? Also, is it ready for review?

we found a regression (thanks @SichenLiang ) but it should be ready now!

The fixed issues are in the commit messages.

xtqqczze · 2026-10-13T17:29:38Z

@anastygnome Could you move GitHub issue references from the commit message to the PR description instead? This makes issues easier to track and avoids spamming the issues with references to individual commits (e.g. #14681).

anastygnome · 2026-10-13T17:42:07Z

@anastygnome Could you move GitHub issue references from the commit message to the PR description instead? This makes issues easier to track and avoids spamming the issues with references to individual commits (e.g. #14681).

@xtqqczze done

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

xtqqczze · 2026-10-13T18:26:01Z

@anastygnome Does this PR supersede #14781 and #14791?

anastygnome · 2026-10-13T18:36:52Z

@anastygnome Does this PR supersede #14781 and #14791?

What do you mean there's more?

Of course,!

Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:56

Copilot AI reviewed Oct 12, 2026

anastygnome force-pushed the test-util branch from 91c3d0d to 85d26e7 Compare October 12, 2026 18:23

Copilot AI balanced review requested due to automatic review settings October 12, 2026 18:23

Copilot AI reviewed Oct 12, 2026

anastygnome force-pushed the test-util branch from 85d26e7 to e7c1723 Compare October 12, 2026 18:32

Copilot AI balanced review requested due to automatic review settings October 12, 2026 18:32

Copilot AI reviewed Oct 12, 2026

anastygnome force-pushed the test-util branch from e7c1723 to b15b029 Compare October 12, 2026 19:48

Copilot AI balanced review requested due to automatic review settings October 12, 2026 19:48

Copilot AI reviewed Oct 12, 2026

anastygnome force-pushed the test-util branch from b15b029 to c445f8c Compare October 13, 2026 03:51

Copilot AI balanced review requested due to automatic review settings October 13, 2026 03:51

Copilot AI reviewed Oct 13, 2026

anastygnome force-pushed the test-util branch from c445f8c to 9334d9d Compare October 13, 2026 04:03

Copilot AI balanced review requested due to automatic review settings October 13, 2026 04:03

Copilot AI reviewed Oct 13, 2026

anastygnome force-pushed the test-util branch from 9334d9d to b23c91c Compare October 13, 2026 04:37

Copilot AI balanced review requested due to automatic review settings October 13, 2026 05:23

anastygnome force-pushed the test-util branch from b23c91c to 0af1aad Compare October 13, 2026 05:23

Copilot AI reviewed Oct 13, 2026

cakebaker reviewed Oct 13, 2026

View reviewed changes

Comment thread tests/by-util/test_date.rs

cakebaker reviewed Oct 13, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:26

Copilot AI reviewed Oct 13, 2026

Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:26

anastygnome force-pushed the test-util branch from 546e653 to 4dcc800 Compare October 13, 2026 09:26

Copilot AI reviewed Oct 13, 2026

sylvestre reviewed Oct 13, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

anastygnome force-pushed the test-util branch from 22c87c3 to b586575 Compare October 13, 2026 13:53

Copilot AI reviewed Oct 13, 2026

Copilot AI balanced review requested due to automatic review settings October 13, 2026 14:59

anastygnome force-pushed the test-util branch from b586575 to c64e6e7 Compare October 13, 2026 14:59

Copilot started reviewing on behalf of anastygnome October 13, 2026 15:00 View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Comment thread src/uu/date/src/date.rs Outdated

Comment thread src/uu/date/src/date.rs Outdated

Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:58

anastygnome force-pushed the test-util branch from c64e6e7 to 60df587 Compare October 13, 2026 15:58

Copilot AI reviewed Oct 13, 2026

Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:11

anastygnome force-pushed the test-util branch from 60df587 to 1a1a9b3 Compare October 13, 2026 17:11

Copilot AI reviewed Oct 13, 2026

anastygnome and others added 5 commits October 13, 2026 19:44

date: ignore weekdays in explicit calendar dates

95032a2

Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>

date: reject setting with another date source

23ddbf0

date: fix optional ISO format parsing

42e862a

date: localize custom percent-c formats

2ec83f7

date: fix %F handling

96328d7

anastygnome force-pushed the test-util branch from 1a1a9b3 to 96328d7 Compare October 13, 2026 17:45

Conversation

anastygnome commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

anastygnome commented Oct 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 3.45%

Performance Changes

Footnotes

Uh oh!

anastygnome commented Oct 13, 2026

Merging this PR will degrade performance by 3.66%

Uh oh!

anastygnome commented Oct 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

SichenLiang commented Oct 13, 2026

Uh oh!

xtqqczze commented Oct 13, 2026

Merging this PR will degrade performance by 3.66%

Uh oh!

xtqqczze commented Oct 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

anastygnome commented Oct 13, 2026

Uh oh!

anastygnome commented Oct 13, 2026

Uh oh!

xtqqczze commented Oct 13, 2026

Uh oh!

anastygnome commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtqqczze commented Oct 13, 2026

Uh oh!

anastygnome commented Oct 12, 2026 •

edited

Loading

codspeed Bot commented Oct 13, 2026 •

edited

Loading

anastygnome commented Oct 13, 2026 •

edited

Loading