Repository navigation
Move the Hub-Tooling Disproved Claims Entries Into the Code They Constrain - #2742
Conversation
…train The Disproved Claims preamble now says an entry is never about hub-hosted machinery, so the four entries about the configuration script, the review digest, the merge-bot reusable workflow, and the host installer move out of the ledger. Each constraint now sits beside the code it constrains, where the claims check already carried its own. The STANDUP.md entry stays, since it is prose rather than tooling. The preamble's 43-word sentence is split in two. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name the repository as the subject of the split preamble sentence and bring its first half under the sentence limit. Keep the walk/1 comment chain in configure.sh unbroken. State the full property-name rule in the merge-bot comment, with its evidence on the dot-notation claim. Carry the rejected path-arm measurement into the claims comment, since the deleted entry was its only record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added
the
comments
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change clarifies repository guidance and code comments; no material merge-blocking risk is established. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and specifically describes the main change: moving hub-tooling disproved-claim entries into comments beside the code they constrain. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
|
There was a problem hiding this comment.
🟡 Changes recommended
The new configure.sh comment includes a commit hash that the repository's comment rules prohibit.
1 open finding
What changed in this PR
This PR moves four hub-tooling disproved claims out of the shared Copilot instructions and places their constraints beside the code they describe.
Changes:
- Adds compatibility and parsing explanations near the relevant code and workflow.
- Removes the four ledger entries and shortens a long preamble sentence.
| File | Description |
|---|---|
scripts/pr_review.py |
Records the rejected path-matching measurement. |
repo-config/configure.sh |
Explains jq compatibility beside the normalizer. |
host-setup/linux/install-tools.sh |
Documents the --query slave format. |
.github/workflows/merge-bot-task.yml |
Documents hyphenated expression properties. |
.github/copilot-instructions.md |
Removes the four entries and revises the preamble. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2742 +/- ##
========================================
Coverage 59.83% 59.83%
========================================
Files 16 16
Lines 8368 8368
========================================
Hits 5007 5007
Misses 3361 3361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…mment A code comment names no commit, and the build string's suffix is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Declining the CodeRabbit "Docstring Coverage" pre-merge warning. This diff adds no function and changes no function body. It adds comment lines beside |
…2744) ## Summary Fixes a finding Copilot raised on promotion #2743. The comment line #2742 added to `.github/workflows/merge-bot-task.yml` ran to 27 words, over the 25-word limit for new prose. The prose gate's sentence-length check reads Markdown only, so it did not catch this. The line now reads "A property name may start with a letter or `_` and continue with letters, digits, `-`, and `_`, so these names need no index syntax." That is 25 words, and the leading-character condition is still there. A hand count of every comment sentence that develop adds over main found none over 25. Part of #2680. ## Test plan - [x] `prose_lint.py --diff` (with `--allow-comments`, and with `--check sentence-length`) - [x] `local-strict-review` pass, attested, 0 findings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
## Summary Promotes 2 changes from `develop` to `main`: - #2744: Bring the Merge-Bot Property-Name Comment Under the Sentence Limit - #2742: Move the Hub-Tooling Disproved Claims Entries Into the Code They Constrain Closes #2680 ## Review coverage #2742 was reviewed in full on its final head `254237f0`: - Copilot raised one finding, which was fixed. - CodeRabbit reviewed the whole range `043a10eb..254237f` and generated no actionable comments. - A local strict-review pass was attested on that head. Copilot's round on this promotion's first head (`3e9e2e88`, identical in tree to #2742's reviewed head) raised one nit, a 27-word comment sentence. #2744 fixed it, and on `ade2beb1` it was covered by Copilot (0 findings) and an attested local pass. CodeRabbit was rate-limited on #2744 and on this promotion. Its one included review this hour went to #2742. Any reader can re-run these checks: - `git rev-parse 5147099^{tree}` and `git rev-parse ade2beb^{tree}` both print `eb1a3da64295fe32ac086a34b0a08ff2206482e1`. - `git rev-parse 254237f^{tree}` and `git rev-parse 3e9e2e8^{tree}` both print `6a11deed1f69494f15f12e60e4bb87c0a59aaa86`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Part of #2680. The "Disproved Claims" preamble in
.github/copilot-instructions.mdsays an entry is never about hub-hosted machinery, and that a constraint on that tooling is recorded in that tooling's code. Four entries still contradicted it. This change deletes them and keeps each constraint beside the code it constrains:keys_unsortedon jq 1.5 moves to a comment beside thenormfilter inrepo-config/configure.sh. I re-ran it this session onjq-1.5-1-a5b5cbe(ubuntu:18.04):keys_unsortedevaluates andwalk(.)answersjq: 1 compile error.claimsmethod. TheBODY_CLAIMcomment inscripts/pr_review.pyalready carried this disproof, so the only addition is the rejected path-arm measurement. The deleted entry was its only record..github/workflows/merge-bot-task.yml, with the full property-name rule (a leading letter or_) and thesteps.app-token.outputs.tokenusage the same file already resolves.sudo_implementations()'s--queryslave format moves beside the function inhost-setup/linux/install-tools.sh. The--queryformat was re-checked on this host: space-separatedname path, no colon.host-setup/is hub-local, so the rule covers it.The
STANDUP.mdsubject-verb entry stays. It is prose rather than tooling, so the rule does not reach it.The preamble sentence opening "Each names a file and a revision" ran to 43 words. It is now three sentences, each under the 25-word limit.
Comments label
This change exists to record constraints as code comments, which is the case the
commentslabel covers. The rule in the preamble requires those comments.Local review
Two
local-strict-reviewpasses ran. The first raised seven findings: the split sentence was still 27 words, the new pronoun bound to the wrong subject, the configure.sh line broke a causal chain, the merge-bot rule left out the leading-character condition and attached its evidence to the wrong claim, and the path-arm measurement was not carried over. All were fixed in 1fc367b. One finding was declined as pre-existing:TODO.md's decision-cluster "Checked" line cites the deletedkeys_unsortedentry, but it is history pinned to7bc6978. The second pass found nothing.Test plan
prose_lint.py --diff(with--allow-comments, and with--check sentence-length)repo_gate.py,spec/validate.pydocker_lint.py(all linters, then actionlint, shellcheck, and shfmt after the fix round)🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation