Repository navigation
Bring the Merge-Bot Property-Name Comment Under the Sentence Limit - #2744
Conversation
The comment line added for the hyphenated-inputs disproof ran to 27 words, over the 25-word limit for new prose, which the prose gate checks in Markdown only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ptr727
added
the
comments
|
A recorded local strict-review pass covers head |
|
@coderabbitai review |
|
There was a problem hiding this comment.
🟢 Approval recommended
The comment-only change preserves meaning and has no unresolved findings.
0 open findings
What changed in this PR
Shortens the merge-bot workflow comment to meet the 25-word sentence limit while preserving its syntax guidance.
Changes:
- Rephrases the property-name comment.
- Preserves the allowed-character rules.
| File | Description |
|---|---|
.github/workflows/merge-bot-task.yml |
Updates the property-name syntax comment. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2744 +/- ##
========================================
Coverage 59.83% 59.83%
========================================
Files 16 16
Lines 8368 8368
========================================
Hits 5007 5007
Misses 3361 3361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## Summary Promotes 2 changes from `develop` to `main`: - #2744: Bring the Merge-Bot Property-Name Comment Under the Sentence Limit - #2742: Move the Hub-Tooling Disproved Claims Entries Into the Code They Constrain Closes #2680 ## Review coverage #2742 was reviewed in full on its final head `254237f0`: - Copilot raised one finding, which was fixed. - CodeRabbit reviewed the whole range `043a10eb..254237f` and generated no actionable comments. - A local strict-review pass was attested on that head. Copilot's round on this promotion's first head (`3e9e2e88`, identical in tree to #2742's reviewed head) raised one nit, a 27-word comment sentence. #2744 fixed it, and on `ade2beb1` it was covered by Copilot (0 findings) and an attested local pass. CodeRabbit was rate-limited on #2744 and on this promotion. Its one included review this hour went to #2742. Any reader can re-run these checks: - `git rev-parse 5147099^{tree}` and `git rev-parse ade2beb^{tree}` both print `eb1a3da64295fe32ac086a34b0a08ff2206482e1`. - `git rev-parse 254237f^{tree}` and `git rev-parse 3e9e2e8^{tree}` both print `6a11deed1f69494f15f12e60e4bb87c0a59aaa86`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Fixes a finding Copilot raised on promotion #2743. The comment line #2742 added to
.github/workflows/merge-bot-task.ymlran to 27 words, over the 25-word limit for new prose. The prose gate's sentence-length check reads Markdown only, so it did not catch this.The line now reads "A property name may start with a letter or
_and continue with letters, digits,-, and_, so these names need no index syntax." That is 25 words, and the leading-character condition is still there. A hand count of every comment sentence that develop adds over main found none over 25.Part of #2680.
Test plan
prose_lint.py --diff(with--allow-comments, and with--check sentence-length)local-strict-reviewpass, attested, 0 findings🤖 Generated with Claude Code