Promote the Disproved Claims Move Into Hub-Tooling Code to Main by ptr727 · Pull Request #2743 · ptr727/ProjectTemplate

ptr727 · 2026-10-10T18:45:19Z

Summary

Promotes 2 changes from develop to main:

Bring the Merge-Bot Property-Name Comment Under the Sentence Limit #2744: Bring the Merge-Bot Property-Name Comment Under the Sentence Limit
Move the Hub-Tooling Disproved Claims Entries Into the Code They Constrain #2742: Move the Hub-Tooling Disproved Claims Entries Into the Code They Constrain

Review coverage

#2742 was reviewed in full on its final head 254237f0:

Copilot raised one finding, which was fixed.
CodeRabbit reviewed the whole range 043a10eb..254237f0 and generated no actionable comments.
A local strict-review pass was attested on that head.

Copilot's round on this promotion's first head (3e9e2e88, identical in tree to #2742's reviewed head) raised one nit, a 27-word comment sentence. #2744 fixed it, and on ade2beb1 it was covered by Copilot (0 findings) and an attested local pass. CodeRabbit was rate-limited on #2744 and on this promotion. Its one included review this hour went to #2742.

Any reader can re-run these checks:

git rev-parse 51470992^{tree} and git rev-parse ade2beb1^{tree} both print eb1a3da64295fe32ac086a34b0a08ff2206482e1.
git rev-parse 254237f0^{tree} and git rev-parse 3e9e2e88^{tree} both print 6a11deed1f69494f15f12e60e4bb87c0a59aaa86.

🤖 Generated with Claude Code

…train (#2742) ## Summary Part of #2680. The "Disproved Claims" preamble in `.github/copilot-instructions.md` says an entry is never about hub-hosted machinery, and that a constraint on that tooling is recorded in that tooling's code. Four entries still contradicted it. This change deletes them and keeps each constraint beside the code it constrains: - **`keys_unsorted` on jq 1.5** moves to a comment beside the `norm` filter in `repo-config/configure.sh`. I re-ran it this session on `jq-1.5-1-a5b5cbe` (`ubuntu:18.04`): `keys_unsorted` evaluates and `walk(.)` answers `jq: 1 compile error`. - **The bare-SHA `claims` method.** The `BODY_CLAIM` comment in `scripts/pr_review.py` already carried this disproof, so the only addition is the rejected path-arm measurement. The deleted entry was its only record. - **Hyphenated inputs in dot notation** move to the header of `.github/workflows/merge-bot-task.yml`, with the full property-name rule (a leading letter or `_`) and the `steps.app-token.outputs.token` usage the same file already resolves. - **`sudo_implementations()`'s `--query` slave format** moves beside the function in `host-setup/linux/install-tools.sh`. The `--query` format was re-checked on this host: space-separated `name path`, no colon. `host-setup/` is hub-local, so the rule covers it. The `STANDUP.md` subject-verb entry stays. It is prose rather than tooling, so the rule does not reach it. The preamble sentence opening "Each names a file and a revision" ran to 43 words. It is now three sentences, each under the 25-word limit. ## Comments label This change exists to record constraints as code comments, which is the case the `comments` label covers. The rule in the preamble requires those comments. ## Local review Two `local-strict-review` passes ran. The first raised seven findings: the split sentence was still 27 words, the new pronoun bound to the wrong subject, the configure.sh line broke a causal chain, the merge-bot rule left out the leading-character condition and attached its evidence to the wrong claim, and the path-arm measurement was not carried over. All were fixed in 1fc367b. One finding was declined as pre-existing: `TODO.md`'s decision-cluster "Checked" line cites the deleted `keys_unsorted` entry, but it is history pinned to `7bc6978`. The second pass found nothing. ## Test plan - [x] `prose_lint.py --diff` (with `--allow-comments`, and with `--check sentence-length`) - [x] `repo_gate.py`, `spec/validate.py` - [x] `docker_lint.py` (all linters, then actionlint, shellcheck, and shfmt after the fix round) 🤖 Generated with [Claude Code](https://claude.com/claude-code)  ## Summary by CodeRabbit * **Bug Fixes** * Improved how repository checks compare ruleset parameters and identify commit references in pull request descriptions. * **Documentation** * Clarified supported expression property-name syntax and documented the format of system command output used by setup checks.  --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

ptr727 · 2026-10-10T18:45:23Z

@coderabbitai review

coderabbitai · 2026-10-10T18:45:28Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 86c716d3-8e2b-47af-b32a-24fc769adc4d

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-10-10T18:45:49Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

codecov · 2026-10-10T18:48:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.83%. Comparing base (043a10e) to head (5147099).
⚠️ Report is 358 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   59.83%   59.83%           
=======================================
  Files          16       16           
  Lines        8368     8368           
=======================================
  Hits         5007     5007           
  Misses       3361     3361

Flag	Coverage Δ
python-3.13	`59.83% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

🟢 Approval recommended

The comment-only promotion has no blocking issue; the remaining feedback is a minor sentence-length nit.

1 open finding

Split sentence exceeding the 25-word prose limit · New

What changed in this PR

This promotion moves hub-tooling disproofs from the shared Copilot instructions into comments beside the code they constrain, completing the work described in #2680.

Changes:

Documents four previously rejected claims beside the relevant tooling.
Removes those claims from the shared instructions and shortens the ledger preamble.

File	Description
`scripts/pr_review.py`	Records the rejected path-based claim check.
`repo-config/configure.sh`	Notes jq 1.5 compatibility.
`host-setup/linux/install-tools.sh`	Documents the alternatives query format.
`.github/workflows/merge-bot-task.yml`	Clarifies hyphenated expression properties.
`.github/copilot-instructions.md`	Removes tooling entries and shortens the preamble.

🧠 Review effort: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…2744) ## Summary Fixes a finding Copilot raised on promotion #2743. The comment line #2742 added to `.github/workflows/merge-bot-task.yml` ran to 27 words, over the 25-word limit for new prose. The prose gate's sentence-length check reads Markdown only, so it did not catch this. The line now reads "A property name may start with a letter or `_` and continue with letters, digits, `-`, and `_`, so these names need no index syntax." That is 25 words, and the leading-character condition is still there. A hand count of every comment sentence that develop adds over main found none over 25. Part of #2680. ## Test plan - [x] `prose_lint.py --diff` (with `--allow-comments`, and with `--check sentence-length`) - [x] `local-strict-review` pass, attested, 0 findings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

🟢 Approval recommended

The comment-only changes have no unresolved findings across the five reviewed files.

0 open findings

1 resolved since last review

Split sentence exceeding the 25-word prose limit

🧠 Review effort: Lite

Copilot AI lite review requested due to automatic review settings October 10, 2026 18:45

Copilot started reviewing on behalf of ptr727 October 10, 2026 18:45 View session

Copilot AI reviewed Oct 10, 2026

View reviewed changes

Comment thread .github/workflows/merge-bot-task.yml Outdated

ptr727 mentioned this pull request Oct 10, 2026

Bring the Merge-Bot Property-Name Comment Under the Sentence Limit #2744

Merged

2 tasks done

ptr727 requested a lite review from Copilot October 10, 2026 18:56

Copilot started reviewing on behalf of ptr727 October 10, 2026 18:57 View session

Copilot AI reviewed Oct 10, 2026

View reviewed changes

ptr727 merged commit 991b961 into main Oct 10, 2026
14 checks passed

This was referenced Oct 10, 2026

prose_lint's sentence-length Check Skips Code Comments Although the 25-Word Cap Covers Them #2430

Open

Session Handoff [engineering]: Disproved Claims Moved Into Hub-Tooling Code, Released as 2.0.941, #2650 Next #2745

Closed

Navigation Menu

Repository navigation

Promote the Disproved Claims Move Into Hub-Tooling Code to Main - #2743

Promote the Disproved Claims Move Into Hub-Tooling Code to Main#2743
ptr727 merged 2 commits into
mainfrom
develop

ptr727 commented Oct 10, 2026 •

edited

Loading

Uh oh!

ptr727 commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review coverage

Uh oh!

ptr727 commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

codecov Bot commented Oct 10, 2026 •

edited

Loading