Repository navigation
fix(apple): build on Firebase Apple SDK 13 and require macOS 11 for Swift packages - #18783
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
a285d55 to
3acab7d
Compare
…K 13 Firestore 13 prefixes the pipeline bridge classes, and the Swift package no longer ships FirebaseMLModelDownloader.
SDK 13 prefixes the bridge classes, and the same parser is still built against the unprefixed 12.19.0 names.
clang-format and swift-format reindent the bridge rename and the canImport guard.
Firebase Apple SDK 13 requires macOS 11. CocoaPods stays on 10.15 because that path is still SDK 12.19.0.
…eck 12 Firebase Apple SDK 13 requires app-check 12 under Swift Package Manager, and every GoogleSignIn-iOS release still requires app-check 11, so the auth example cannot resolve its packages under SPM.
3acab7d to
3175041
Compare
Description
Stacked on #18771. The base branch is
feat/bump-ios-sdk-13.0.0, notmain, because these changes only compile against the Firebase Apple SDK 13 Swift Package Manager pin. Merge this into the bump branch first; that turns #18771 green, and then it merges intomain.FLT_FIREBASE_SDK_13and the parser picks the right names for each path.FirebaseMLModelDownloader. With Swift Package Manager, the plugin now depends onFirebaseCoreonly and returns anunimplementederror for every method call. CocoaPods stays on SDK 12.19.0 and keeps working, and the ML Model Downloader end-to-end workflow runs on CocoaPods.Package.swiftfiles move from 10.15 to 11. CocoaPods podspecs keep 10.15. The iOS deployment target is unchanged at 15.0.google_sign_incannot resolve. Bumpinggoogle_sign_indoes not help: the latestgoogle_sign_in_iosstill lands on App Check 11. The auth iOS job now runs on CocoaPods (still SDK 12.19.0) until [App Check] Add SPM AppCheckCore 12.x support google/GoogleSignIn-iOS#626 ships andgoogle_sign_in_iosaccepts that release. Until then, no end-to-end job buildsfirebase_authunder Swift Package Manager on SDK 13.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Swift Package Manager builds require macOS 11, and
firebase_ml_model_downloaderis unavailable with Swift Package Manager. The breaking-change marker for the release lives on the title of #18771, because this pull request is squashed into that branch.Test plan