Skip to content

fix(apple): build on Firebase Apple SDK 13 and require macOS 11 for Swift packages - #18783

Merged
SelaseKay merged 5 commits into
mainfrom
fix/bump-ios-sdk-13.0.0-ci
Oct 13, 2026
Merged

SelaseKay merged 5 commits into
mainfrom
fix/bump-ios-sdk-13.0.0-ci

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Stacked on #18771. The base branch is feat/bump-ios-sdk-13.0.0, not main, because these changes only compile against the Firebase Apple SDK 13 Swift Package Manager pin. Merge this into the bump branch first; that turns #18771 green, and then it merges into main.

  • Firestore pipelines. Firestore 13 prefixes the pipeline bridge classes. The same parser is still built by CocoaPods against Firebase Apple SDK 12.19.0 and its unprefixed names, so the Swift package sets FLT_FIREBASE_SDK_13 and the parser picks the right names for each path.
  • ML Model Downloader. The Firebase Apple SDK 13 Swift package no longer ships FirebaseMLModelDownloader. With Swift Package Manager, the plugin now depends on FirebaseCore only and returns an unimplemented error for every method call. CocoaPods stays on SDK 12.19.0 and keeps working, and the ML Model Downloader end-to-end workflow runs on CocoaPods.
  • macOS 11. Firebase Apple SDK 13 requires macOS 11, so the macOS Package.swift files move from 10.15 to 11. CocoaPods podspecs keep 10.15. The iOS deployment target is unchanged at 15.0.
  • Formatting for the parser and the model downloader guard.
  • Auth iOS end-to-end on CocoaPods. Under Swift Package Manager, Firebase Apple SDK 13 requires App Check 12, but every GoogleSignIn-iOS release up to 10.0.0 requires App Check 11, so the auth example's google_sign_in cannot resolve. Bumping google_sign_in does not help: the latest google_sign_in_ios still lands on App Check 11. The auth iOS job now runs on CocoaPods (still SDK 12.19.0) until [App Check] Add SPM AppCheckCore 12.x support google/GoogleSignIn-iOS#626 ships and google_sign_in_ios accepts that release. Until then, no end-to-end job builds firebase_auth under Swift Package Manager on SDK 13.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Swift Package Manager builds require macOS 11, and firebase_ml_model_downloader is unavailable with Swift Package Manager. The breaking-change marker for the release lives on the title of #18771, because this pull request is squashed into that branch.

Test plan

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay SelaseKay mentioned this pull request Oct 12, 2026
6 of 10 tasks
@SelaseKay
SelaseKay added this pull request to stack #18784 October 12, 2026 10:36
@SelaseKay
SelaseKay force-pushed the fix/bump-ios-sdk-13.0.0-ci branch 4 times, most recently from a285d55 to 3acab7d Compare October 13, 2026 11:06
Base automatically changed from feat/bump-ios-sdk-13.0.0 to main October 13, 2026 11:34
…K 13

Firestore 13 prefixes the pipeline bridge classes, and the Swift package no longer ships FirebaseMLModelDownloader.
SDK 13 prefixes the bridge classes, and the same parser is still built against the unprefixed 12.19.0 names.
clang-format and swift-format reindent the bridge rename and the canImport guard.
Firebase Apple SDK 13 requires macOS 11. CocoaPods stays on 10.15 because that path is still SDK 12.19.0.
…eck 12

Firebase Apple SDK 13 requires app-check 12 under Swift Package Manager, and every GoogleSignIn-iOS release still requires app-check 11, so the auth example cannot resolve its packages under SPM.
@SelaseKay
SelaseKay force-pushed the fix/bump-ios-sdk-13.0.0-ci branch from 3acab7d to 3175041 Compare October 13, 2026 11:34
@SelaseKay
SelaseKay merged commit aca14ea into main Oct 13, 2026
123 of 125 checks passed
@SelaseKay
SelaseKay deleted the fix/bump-ios-sdk-13.0.0-ci branch October 13, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants