Skip to content

fix(apple): build on Firebase Apple SDK 13 and require macOS 11 for Swift packages #18783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 5 commits into from
Oct 13, 2026
+442 −372
Merged

fix(apple): build on Firebase Apple SDK 13 and require macOS 11 for Swift packages #18783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c346294
fix(apple): compile Firestore pipelines and ML Model Downloader on SD…
SelaseKay Oct 12, 2026
74666ce
fix(firestore): keep pipeline bridges compiling on CocoaPods 12.19.0
SelaseKay Oct 12, 2026
dce61e5
style(apple): format the SDK 13 pipeline parser and model downloader
SelaseKay Oct 12, 2026
1265a9a
refactor(apple)!: require macOS 11 for the Swift packages on SDK 13
SelaseKay Oct 12, 2026
3175041
ci(auth): run iOS e2e on CocoaPods until GoogleSignIn supports App Ch…
SelaseKay Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/e2e_tests_auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ jobs:
# FIRInstallations aborts on at launch.
native-config-args: '--live-tier-plist=auth'
inject-config-secrets: true
# Firebase Apple SDK 13 needs app-check 12, and every GoogleSignIn-iOS
# release (8.0.0 to 10.0.0) needs app-check 11, so the example's
# google_sign_in cannot resolve under SPM. CocoaPods is still on 12.19.0.
# Rejoin SPM once https://github.com/google/GoogleSignIn-iOS/pull/626
# ships and google_sign_in_ios accepts that release.
ios-spm: false
nightly_test_mode: ${{ inputs.nightly_test_mode == true }}
secrets:
TESTS_E2E_FIREBASE_OPTIONS_DART: ${{ secrets.TESTS_E2E_FIREBASE_OPTIONS_DART }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_tests_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
# 26.2 pin (see `reusable_e2e_ios.yaml`) is the likely fix, but one
# variable at a time - these two rejoin SPM once the default-Xcode runs
# prove clean. iOS SPM coverage is unaffected meanwhile: storage,
# database, firestore and auth still build under it.
# database and firestore still build under it.
ios-spm: false
native-config-args: '--functions-native'
nightly_test_mode: ${{ inputs.nightly_test_mode == true }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/e2e_tests_ml_model_downloader.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ jobs:
native-config-args: '--live-tier-plist=ml_model_downloader'
inject-config-secrets: true
use-firebase-emulators: false
# Firebase Apple SDK 13 removed FirebaseMLModelDownloader. Live tests stay
# on CocoaPods, which is still pinned to 12.19.0.
ios-spm: false
nightly_test_mode: ${{ inputs.nightly_test_mode == true }}
secrets:
TESTS_E2E_FIREBASE_OPTIONS_DART: ${{ secrets.TESTS_E2E_FIREBASE_OPTIONS_DART }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_tests_performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
# 26.2 pin (see `reusable_e2e_ios.yaml`) is the likely fix, but one
# variable at a time - these two rejoin SPM once the default-Xcode runs
# prove clean. iOS SPM coverage is unaffected meanwhile: storage,
# database, firestore and auth still build under it.
# database and firestore still build under it.
ios-spm: false
native-config-args: '--live-tier-plist=performance'
inject-config-secrets: true
Expand Down
1 change: 1 addition & 0 deletions packages/cloud_firestore/cloud_firestore/ios/cloud_firestore/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ let package = Package(
.headerSearchPath("include/cloud_firestore/Public"),
.define("LIBRARY_VERSION", to: "\"\(libraryVersion)\""),
.define("LIBRARY_NAME", to: "\"flutter-fire-fst\""),
.define("FLT_FIREBASE_SDK_13"),
]
)
]
Expand Down
507 changes: 274 additions & 233 deletions ...firestore/cloud_firestore/ios/cloud_firestore/Sources/cloud_firestore/FLTPipelineParser.m
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/cloud_firestore/cloud_firestore/macos/cloud_firestore/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "cloud_firestore",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "cloud-firestore", targets: ["cloud_firestore"])
Expand All @@ -39,6 +39,7 @@ let package = Package(
.headerSearchPath("include/cloud_firestore/Public"),
.define("LIBRARY_VERSION", to: "\"\(libraryVersion)\""),
.define("LIBRARY_NAME", to: "\"flutter-fire-fst\""),
.define("FLT_FIREBASE_SDK_13"),
]
)
]
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_functions/cloud_functions/macos/cloud_functions/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "cloud_functions",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "cloud-functions", targets: ["cloud_functions"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_ai/firebase_ai/macos/firebase_ai/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import PackageDescription
let package = Package(
name: "firebase_ai",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-ai", targets: ["firebase_ai"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_analytics/firebase_analytics/macos/firebase_analytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_analytics",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-analytics", targets: ["firebase_analytics"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_app_check/firebase_app_check/macos/firebase_app_check/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_app_check",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-app-check", targets: ["firebase_app_check"])
Expand Down
2 changes: 1 addition & 1 deletion ...p_installations/firebase_app_installations/macos/firebase_app_installations/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_app_installations",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-app-installations", targets: ["firebase_app_installations"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/firebase_auth/macos/firebase_auth/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_auth",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-auth", targets: ["firebase_auth"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_core/firebase_core/macos/firebase_core/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_core",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-core", targets: ["firebase_core", "firebase_core_objc"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_crashlytics/firebase_crashlytics/macos/firebase_crashlytics/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_crashlytics",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-crashlytics", targets: ["firebase_crashlytics"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_database/firebase_database/macos/firebase_database/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_database",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-database", targets: ["firebase_database"])
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_messaging/firebase_messaging/macos/firebase_messaging/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let firebaseSdkVersion: Version = "13.0.0"
let package = Package(
name: "firebase_messaging",
platforms: [
.macOS("10.15")
.macOS("11.0")
],
products: [
.library(name: "firebase-messaging", targets: ["firebase_messaging"])
Expand Down
2 changes: 1 addition & 1 deletion ...el_downloader/firebase_ml_model_downloader/ios/firebase_ml_model_downloader/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ let package = Package(
.target(
name: "firebase_ml_model_downloader",
dependencies: [
.product(name: "FirebaseMLModelDownloader", package: "firebase-ios-sdk"),
.product(name: "FirebaseCore", package: "firebase-ios-sdk"),
.product(name: "firebase-core", package: "firebase_core"),
.product(name: "FlutterFramework", package: "FlutterFramework"),
],
Expand Down
Loading
Loading