Repository navigation
[SCF-2416] [Part 8] ember-cli-update to the 5.4 addon blueprint - #23
Open
Gaurav0 wants to merge 2 commits into
Conversation
Runs `ember-cli-update --to 5.4.2` from the 3.28.6 addon blueprint. The blueprint's dependency upgrades landed in the preceding commits; this one bumps ember-cli itself and syncs the blueprint files. ember-cli 5.3 removed the "not tested against Node X" platform check, so ember-cli ~5.4.2 runs on Node 20 without the warning. Dependencies: - ember-cli ~5.4.2. - ember-cli-clean-css, since ember-cli 5 no longer minifies CSS itself. - Held back for lint churn (follow-up): ember-template-lint stays ^3 (v5 reports 168 errors, including a11y rules on addon templates), and eslint-plugin-qunit stays ^6 (v8 adds 44 no-assert-equal errors). Config: - config/ember-try.js moves to tests/dummy/config/ (blueprint layout) unchanged. The empty root config/environment.js is gone. - Blueprint updates to the dotfiles and ignore files, the X-UA-Compatible meta tags, CONTRIBUTING's ember-cli link, and the new tests/helpers/index.js. - Our README, CI workflow and lint rule customizations are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Finishes what "upgrade test tooling toward the 5.4 blueprint versions" held back. On ember-cli 3.28, ember-qunit 8 failed with "Testem was unable to detect a test framework"; on ember-cli 5.4 it works with the existing tests/test-helper.js, which already matches the blueprint. - @ember/test-helpers ^3.2.0 and ember-qunit ^8.0.1, the 5.4 blueprint versions. - ember-a11y-testing ^6.1.1 (4.x only accepts test-helpers ^2) and ember-cli-fastboot-testing ^0.7.0 (0.6.2+ wants test-helpers >= 3). - Drop the ember-a11y-testing/ember-auto-import resolution: a11y 6 asks for ember-auto-import ^2.2.4 itself, so the ember-auto-import 1.x copy is gone. - tests/helpers/setup-stylesheet-support.js: ember-qunit 8 no longer ships test-support.css, so under Embroider there is no such stylesheet and the 9 tests that call insertCSSRule threw. Insert into dummy.css instead, at cssRules.length (CSSStyleSheet has no length, so rules went to index 0, where they'd lose to bootstrap's). Same as upstream ember-bootstrap#2224. test-helpers 2.9 was the last thing pulling npm's @embroider/util 1.13.3, so only the fork remains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
[SCF-2416] [Part 2] Upgrade test and lint tooling (ESLint 8, Prettier 3, ember-try 3, stylelint)
#17
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The blueprint's dependency upgrades landed in Parts 2–6. This part bumps ember-cli itself and syncs the blueprint files.
ember-cli-update --to 5.4.2from the 3.28.6 addon blueprint, with ember-cli ~5.4.2.ember-cli-clean-cssis added.config/ember-try.jsmoves totests/dummy/config/unchanged, and the empty rootconfig/environment.jsis removed.tests/helpers/index.js.ember-template-lintstays ^3 (v5 reports 168 errors) andeslint-plugin-qunitstays ^6.@ember/test-helpers^3.2.0,ember-qunit^8.0.1,ember-a11y-testing^6.1.1 andember-cli-fastboot-testing^0.7.0. Theember-a11y-testing/ember-auto-importresolution is dropped.test-support.css, sosetup-stylesheet-support.jsnow inserts intodummy.cssatcssRules.length(as upstream Update dependency ember-qunit to v9 ember-bootstrap/ember-bootstrap#2224).@embroider/util, so only the fork remains.+71/−54 lines, not counting
yarn.lock.Stack
Part of the SCF-2416 work (ember-bootstrap 5.0.0), split from
scf-2416-reworkfor easier review. This is part 8 of 9. Stacked on Part 7: its base isgaurav/chore/SCF-2416-part-7-keep-bootstrap-3-and-subclassing, so the diff only shows this part. Merge in order.Review notes
The first commit is mostly blueprint output. The
tests/helpers/setup-stylesheet-support.jsfix in the second commit is the one hand-written change worth reading.Testing
Run on this branch with Node 20.19.6:
yarn install --frozen-lockfilepasses,yarn lintreports 0 errors (the same 150 warnings asscf_master), andember test(Ember 4.8, the default) has 535 passed, 9 skipped and 0 failed. No new tests. CI covers the ember-try matrix.🤖 Generated with Claude Code