Repository navigation
Conversation
5.0.0 drops support for Ember 3.28 and 4.4 and moves @glimmer/component, @glimmer/tracking and ember-modifier to peer dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new minimum is Ember 4.8, as in upstream ember-bootstrap 6.0.0 (ember-bootstrap#1996, ember-bootstrap#2008). This lets ember-bootstrap depend on releases that no longer pull in ember-cli-babel 7 (and with it @babel/runtime 7.12.18 and tmp 0.0.x), several of which require Ember >= 4.8. - package.json: ember-source >=4.8.0 peerDependency, and ember-addon.versionCompatibility raised to >=4.8.0. - Develop and test against ember-source ~4.8.0 by default. The dummy app uses locationType 'history'; 'auto' is deprecated in Ember 4. - Remove the ember-lts-3.28, ember-lts-4.4, ember-default-with-jquery (jQuery integration was removed in Ember 4) and ember-classic (pinned to Ember 3.28) scenarios from ember-try and the CI matrix. - Remove the always-true gte('3.4.0') test branches and the ember-compatibility-helpers devDependency. - README: Ember.js and Ember CLI 4.8 or above, node.js 18+. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er peer dependencies The host app provides these, as in upstream ember-bootstrap (ember-bootstrap#1870 for @glimmer/component and @glimmer/tracking in 6.0.0, ember-modifier in 6.3.1). This makes the expectation explicit and keeps ember-bootstrap from bringing its own copies, so the app's versions are used. The peer ranges match upstream: @glimmer/component ^1.0.4 || ^2.0.0, @glimmer/tracking ^1.0.4 and ember-modifier ^3.2.7 || ^4.0.0. The current versions stay in devDependencies for the dummy app. Breaking: apps must list @glimmer/component, @glimmer/tracking and ember-modifier in their own package.json. The default Ember app blueprint already includes @glimmer/*; ember-modifier may need adding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ember-cli 5 removed bower support, including project.bowerDependencies(), so `ember install ember-bootstrap` crashed in the blueprint's afterInstall on ember-cli 5+. Skip the bower cleanup when the method is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
[SCF-2416] [Part 2] Upgrade test and lint tooling (ESLint 8, Prettier 3, ember-try 3, stylelint)
#17
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts the 5.0.0 major: the new minimum is Ember 4.8, as in upstream ember-bootstrap 6.0.0. Most later parts in this stack need this, because the releases that stop pulling in ember-cli-babel 7 (and with it
@babel/runtime7.12.18 andtmp0.0.x) require Ember >= 4.8.ember-source >=4.8.0peer andversionCompatibility, and develops against~4.8.0by default. Removes theember-lts-3.28,ember-lts-4.4,ember-default-with-jqueryandember-classicscenarios from ember-try and CI, plus the always-truegte('3.4.0')test branches.@glimmer/component(^1.0.4 || ^2.0.0),@glimmer/tracking(^1.0.4) andember-modifier(^3.2.7 || ^4.0.0), with the same ranges as upstream.ember install ember-bootstrapno longer crashes on ember-cli 5+, which removedproject.bowerDependencies().+24/−91 lines, not counting
yarn.lock.Breaking changes (5.0.0 release notes)
@glimmer/component,@glimmer/trackingandember-modifierin their ownpackage.json. The default app blueprint already has@glimmer/*.ember-modifiermay need adding.Stack
Part of the SCF-2416 work (ember-bootstrap 5.0.0), split from
scf-2416-reworkfor easier review. This is part 1 of 9. Based onscf_master, so the diff only shows this part. Merge in order.Review notes
Most of the diff is removed compatibility code. The
package.jsonpeer ranges and the ember-try/CI scenario list are what matter.Testing
Run on this branch with Node 20.19.6:
yarn install --frozen-lockfilepasses,yarn lintreports 0 errors (the same 150 warnings asscf_master), andember test(Ember 4.8, the default) has 532 passed, 9 skipped and 0 failed. Same counts asscf_master, which ran them on Ember 3.28. CI covers the ember-try matrix.🤖 Generated with Claude Code