Repository navigation
Conversation
ember-cli-babel ^8.3.2 is the first release that no longer pins @babel/runtime 7.12.18. Following ember-cli-babel 8's UPGRADING guide for v1 addons, @babel/core moves from devDependencies into dependencies. ember-cli-babel 8 removed the includePolyfill option, so ember-cli-build.js stops passing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…2.6.3 The 5.4 addon blueprint's versions of the two addon build dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…yfill Both polyfills are no-ops on Ember >= 3.25, and ember-bootstrap now requires Ember >= 4.8 (upstream ember-bootstrap#1854). Each one still pulled in ember-cli-babel 7. BsAlert's docs no longer suggest installing the named blocks polyfill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BsCollapse's camelize call was the only use of @ember/string, and it only ever turned "scroll-height"/"offset-width" and the like into property names, so it's inlined (upstream ember-bootstrap#1849). New tests cover the expanded size for both @collapseDimension values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
[SCF-2416] [Part 2] Upgrade test and lint tooling (ESLint 8, Prettier 3, ember-try 3, stylelint)
#17
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves ember-bootstrap's own build dependencies off ember-cli-babel 7, which is what pulls
@babel/runtime7.12.18 into consumer installs.@babel/runtime7.12.18. Following its v1-addon upgrade guide,@babel/coremoves intodependencies, andember-cli-build.jsstops passing the removedincludePolyfilloption.ember-in-element-polyfillandember-named-blocks-polyfill. Both are no-ops on Ember >= 3.25, and each still pulled in ember-cli-babel 7. BsAlert's docs no longer suggest the named-blocks polyfill.@ember/string. BsCollapse's onecamelizecall is inlined (upstream drop dependency on @ember/string ember-bootstrap/ember-bootstrap#1849). New tests cover the expanded size for both@collapseDimensionvalues.+36/−16 lines, not counting
yarn.lock.Stack
Part of the SCF-2416 work (ember-bootstrap 5.0.0), split from
scf-2416-reworkfor easier review. This is part 3 of 9. Stacked on Part 2: its base isgaurav/chore/SCF-2416-part-2-test-and-lint-tooling, so the diff only shows this part. Merge in order.Review notes
The
bs-collapse.jschange is the only runtime code change.bs-alert.jsonly loses a doc paragraph.Testing
Run on this branch with Node 20.19.6:
yarn install --frozen-lockfilepasses,yarn lintreports 0 errors (the same 150 warnings asscf_master), andember test(Ember 4.8, the default) has 534 passed, 9 skipped and 0 failed. +2 BsCollapse tests. CI covers the ember-try matrix.🤖 Generated with Claude Code