Skip to content

[SCF-2416] [Part 3] Upgrade build dependencies and drop polyfills - #18

Open
Gaurav0 wants to merge 4 commits into
gaurav/chore/SCF-2416-part-2-test-and-lint-toolingfrom
gaurav/chore/SCF-2416-part-3-build-deps
Open

Gaurav0 wants to merge 4 commits into
gaurav/chore/SCF-2416-part-2-test-and-lint-toolingfrom
gaurav/chore/SCF-2416-part-3-build-deps

Conversation

@Gaurav0

@Gaurav0 Gaurav0 commented Nov 5, 2026 •

Copy link
Copy Markdown

Summary

Moves ember-bootstrap's own build dependencies off ember-cli-babel 7, which is what pulls @babel/runtime 7.12.18 into consumer installs.

  • ember-cli-babel ^8.3.2, the first release that doesn't pin @babel/runtime 7.12.18. Following its v1-addon upgrade guide, @babel/core moves into dependencies, and ember-cli-build.js stops passing the removed includePolyfill option.
  • ember-cli-htmlbars 6 and ember-auto-import ^2.6.3, the 5.4 blueprint versions.
  • Removed ember-in-element-polyfill and ember-named-blocks-polyfill. Both are no-ops on Ember >= 3.25, and each still pulled in ember-cli-babel 7. BsAlert's docs no longer suggest the named-blocks polyfill.
  • Removed @ember/string. BsCollapse's one camelize call is inlined (upstream drop dependency on @ember/string ember-bootstrap/ember-bootstrap#1849). New tests cover the expanded size for both @collapseDimension values.

+36/−16 lines, not counting yarn.lock.

Stack

Part of the SCF-2416 work (ember-bootstrap 5.0.0), split from scf-2416-rework for easier review. This is part 3 of 9. Stacked on Part 2: its base is gaurav/chore/SCF-2416-part-2-test-and-lint-tooling, so the diff only shows this part. Merge in order.

Part PR Title
1 #16 Drop Ember 3.28 and 4.4, bump to 5.0.0
2 #17 Upgrade test and lint tooling (ESLint 8, Prettier 3, ember-try 3, stylelint)
3 this PR Upgrade build dependencies and drop polyfills
4 #19 Require Node 20 and switch @embroider/util to a fork
5 #20 Replace ember-on-helper and ember-ref-bucket
6 #21 Upgrade addon dependencies off ember-cli-babel 7
7 #22 Keep Bootstrap 3 and subclassing, drop their deprecations
8 #23 ember-cli-update to the 5.4 addon blueprint
9 #24 Force and refresh remaining vulnerable dependencies

Review notes

The bs-collapse.js change is the only runtime code change. bs-alert.js only loses a doc paragraph.

Testing

Run on this branch with Node 20.19.6: yarn install --frozen-lockfile passes, yarn lint reports 0 errors (the same 150 warnings as scf_master), and ember test (Ember 4.8, the default) has 534 passed, 9 skipped and 0 failed. +2 BsCollapse tests. CI covers the ember-try matrix.

🤖 Generated with Claude Code

Gaurav0 and others added 4 commits November 5, 2026 09:02
ember-cli-babel ^8.3.2 is the first release that no longer pins
@babel/runtime 7.12.18. Following ember-cli-babel 8's UPGRADING guide
for v1 addons, @babel/core moves from devDependencies into
dependencies.

ember-cli-babel 8 removed the includePolyfill option, so ember-cli-build.js
stops passing it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…2.6.3

The 5.4 addon blueprint's versions of the two addon build dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…yfill

Both polyfills are no-ops on Ember >= 3.25, and ember-bootstrap now
requires Ember >= 4.8 (upstream ember-bootstrap#1854). Each one still pulled in
ember-cli-babel 7.

BsAlert's docs no longer suggest installing the named blocks polyfill.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BsCollapse's camelize call was the only use of @ember/string, and it
only ever turned "scroll-height"/"offset-width" and the like into
property names, so it's inlined (upstream ember-bootstrap#1849).

New tests cover the expanded size for both @collapseDimension values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant