Repository navigation
Accept stable residual pressure when a zero target cannot be reached exactly - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-target steps previously depended entirely on the instrument's IN LIMIT flag and could time out while pressure had stopped falling near zero. Add an alternative plateau criterion only for an exact zero target: residual within ±0.5 bar, pressure range ≤0.01 bar over 10 seconds, with valid readings and no telemetry gap above three polling intervals (at least three seconds).
Manual, indenting and routine steps can complete or begin their configured dwell using this condition. Nonzero targets keep the hardware IN LIMIT criterion. Telemetry failures, CONTROL exit, disconnection and new pressure steps clear the stability history. UI shows ZERO STABLE / ZERO STABILE while preserving the actual pressure and hardware IN LIMIT flag; diagnostic logs record the accepted residual.
Validation: 46 cross-platform tests and 7 repository checks pass locally; all workflows pass actionlint. New tests cover a stable 0.5 bar residual, continuing ramps, residuals outside tolerance, nonzero targets, missing/invalid readings, dwell/completion and real polling-to-telemetry integration. Instrument validation remains to be performed.