Repository navigation
Fit rolling leak trends and restart measurements after pressure steps - #9
Merged
Merged
Conversation
SebRoLENS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loss monitoring previously used only endpoint pressures. Fit pressure versus time by ordinary least squares using all readings in each rolling window; loss in bar/h is the negative fitted slope, clipped to zero for rising pressure. This applies to five-minute short term and two-hour long term measurements for both cell and cylinder, retaining immediate startup, window counters and independent controls.
Large discontinuities such as cylinder refills now restart the affected side's short term and active long term windows from the new reading. Compare the change against median recent drift using up to ten intervals; deviation must exceed 0.1 bar and eight times the recent median absolute rate deviation scaled by polling duration. Continuous large drift is retained. Counters return to zero and the on-screen log reports the reset; the other side and stopped results are unaffected.
Validation: 44 cross-platform tests plus 7 repository checks pass locally; all workflows pass actionlint. Tests cover known slopes, irregular timestamps, endpoint noise, two-hour window expiry, positive/negative steps, continuous drift, and per-side short/long reset integration. Updated README, manual and changelog.
Independent of the stable-zero-target change in #8.