Repository navigation
Stop reporting invalid inputs for jobs that only wait for their interface (1.20) - #247
Merged
Merged
Conversation
…face When the target of a crafting interface refused a job's inputs, for example a furnace that was still busy, the job was marked as having invalid inputs. Jobs are only tested again when the interface has room to start one, so once another job started, the refused jobs kept that mark until the running job was done, even if the target had accepted inputs again in the meantime. Terminals showed them as failed for that whole time. Starting a job now clears the mark on the other pending jobs of the same interface, as their earlier test no longer applies. They are tested again on the next attempt, so a target that keeps refusing is still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
If the target refused the inputs on insertion after all, its state did not change, so the other jobs keep their mark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
This was referenced Oct 12, 2026
Member
Author
|
The failing
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #246 to 1.20.
Problem
If a crafting interface's target refuses a job's inputs, the job is marked as having invalid inputs. That happens for example when a furnace is still smelting something else. Pending jobs are only tested again while the interface has room to start a job. So once another job starts, the refused jobs keep reporting
INVALID_INPUTSuntil that job is done, even though they are only waiting for the interface. Terminals show this as a failed "Recipe Not Allowed" job. Crafting itself completes correctly.Fix
Once
CraftingJobHandlerhas inserted a started job into the target, it clears the mark on that handler's other pending jobs, the same change as #246.Testing
./gradlew buildwith Java 17 passes (170 unit tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y