Skip to content

Stop reporting invalid inputs for jobs that only wait for their interface (1.20) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 2 commits into from
Oct 12, 2026
Merged

Stop reporting invalid inputs for jobs that only wait for their interface (1.20) #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d72ce
Stop reporting invalid inputs for jobs that only wait for their inter…
claude Oct 12, 2026
a6c9657
Only clear refused jobs once the started job was inserted
claude Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/org/cyclops/integratedcrafting/core/CraftingJobHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,14 @@ public void update(INetwork network, int channel, PartPos targetPos) {
// Start the actual crafting
boolean couldCraft = consumeAndInsertCrafting(blockingMode, network, channel, targetPos, startingCraftingJob);

// Other jobs that the target refused were tested against its previous state,
// so they are only waiting for this handler now, until they are tested again.
if (couldCraft) {
for (CraftingJob pendingCraftingJob : getPendingCraftingJobs()) {
pendingCraftingJob.setInvalidInputs(false);
}
}

// Keep inserting as much as possible if non-blocking
if (couldCraft && !blockingMode) {
nonBlockingJobsRunningAmount.put(startingCraftingJob.getId(), 1);
Expand Down
Loading