Stop reporting invalid inputs for jobs that only wait for their interface

[rubensworks]

Problem

If a crafting interface's target refuses a job's inputs, the job is marked as having invalid inputs. That happens for example when a furnace is still smelting something else. The job then reports INVALID_INPUTS, which terminals show as "Recipe Not Allowed" in red.

Pending jobs are only tested again while the interface has room to start a job. Once one of the refused jobs starts, that room is gone, so the other refused jobs keep their mark for as long as the running job takes. That stays true even if the target has accepted inputs in the meantime. In a hopper minecart job with iron smelted in a furnace, the second iron job reported INVALID_INPUTS for about 1000 ticks while it was only waiting for the first one. Crafting itself completes correctly; only the reported status is wrong.

Fix

Once CraftingJobHandler has inserted a started job into the target, it clears the mark on that handler's other pending jobs. They were tested against the target's previous state, so they now report PENDING_INTERFACE.

• The marks are only cleared after a successful insertion. If the target refuses the inputs on the real insertion, its state did not change, so the other jobs keep their mark.
• Cleared jobs are tested again on the next attempt, so a target that keeps refusing is still reported.

Testing

• New game test GameTestsItemsCraftBusyTarget.testRefusedJobsWaitForInterfaceOnceAnotherJobStarts:
  • Two smelting jobs are scheduled while the furnace holds raw gold, so both are refused first.
  • Once one of them is processing, the other must report PENDING_INTERFACE.
  • Without the fix it fails with: Expected Status of the waiting job to be PENDING_INTERFACE, but was INVALID_INPUTS.
• ./gradlew build passes, and ./gradlew runGameTestServer passes all 80 game tests.
• Reproduced in game with Integrated Terminals' crafting job view before the fix (furnace pre-filled with raw gold, hopper minecart job). The fix itself was verified with the game test, not in that dev client, which uses the released Integrated Crafting jar.

The same fix for 1.20 is in #247, without the game test. Integrated Terminals also stops showing INVALID_INPUTS as a failure in CyclopsMC/IntegratedTerminals#233.

🤖 Generated with Claude Code

https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y