Repository navigation
fix(mkconcore): launch quoted tool paths correctly in Windows run.bat and debug.bat - #639
Open
Siddhanthguptaa wants to merge 1 commit into
Open
Siddhanthguptaa wants to merge 1 commit into
Siddhanthguptaa wants to merge 1 commit into
Conversation
Quoting tool executables broke two Windows launch lines: - start takes the first quoted argument as the window title, so `start /B /D "CZ" "python" "x.py"` never ran python. Pass an empty title. - cmd /K strips the outer quotes of `"python" "x.py"`. Wrap the payload in one more pair of quotes.
This was referenced Nov 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638
Since #541 quotes tool executables, two Windows launch lines broke:
start /B /D "CZ" "python" "x.py"—starttakes the first quoted argument as the window title (docs), so python never runs. Nowstart "" /B /D ..., the same idiomconcore_cli/commands/editor.pyalready uses.cmd /K "python" "x.py"— cmd strips the first and last quote (docs) and looks forpython" "x.py. Now the payload is wrapped once more:cmd /K ""python" "x.py"", which is what cmd saw before fix(mkconcore): handle tool executable paths with spaces in generated scripts #541.Applied to the Python, Octave and MATLAB lines. C++, Verilog and Java lines start with an unquoted
cmd /c/cmd /Kand are unchanged. posix and docker output are unchanged.Testing
test_build_command_quotes_windows_tool_path_with_spacesto check the exact run.bat and debug.bat lines; it fails on current dev and passes with this change.ruff check .andruff format --check .pass.--eval "run("x.m")"(Windows passesrun(x.m)to Octave); I'll send that as a follow-up PR.Note: the cpp-* CI jobs are currently failing on dev (
tryparamtests in TestConcoreHpp); that is unrelated to this change.