Repository navigation
fix: single quote the .m file name in windows run and debug scripts - #637
bhuvan-somisetty wants to merge 3 commits into
Conversation
|
Heads-up: #639 changes the same Windows run.bat/debug.bat lines in mkconcore.py, so the two PRs will conflict (merging both locally gives a conflict in mkconcore.py). They fix different things on those lines:
So with only one of them, Octave still doesn't run from run.bat. With both applied (Windows 11, Octave 11.3, demo/sampleM.graphml), Octave starts and runs controllerM.m; on my machine it then stops at the first read with Whichever lands second needs a small rebase. I'm happy to rebase #639 on top of this one. |
|
Thanks for testing both together. Yeah they fix different things on that line, so rebasing #639 on top of this works for me. |
|
Follow-up on the read error I mentioned above: the cause is that mkconcore doesn't copy |
|
Nice, good to know it runs end to end with all three. Thanks for tracking that down. |
Fixes #636
The windows MATLAB and Octave lines in mkconcore.py now put the file name in single quotes, so run.bat and debug.bat get
run('cmat.m')again instead ofrun("cmat.m"). With the nested double quotes the tool gotrun(cmat.m). This is the same as the posix scripts and what it was before 991373c. Node labels already reject', so the file name can't break out.Added a test that builds a windows study with a
.mnode and checks run.bat and debug.bat. It fails on dev and passes with this change. I also ran the generated line with a script that prints its argv, and it now getsrun('cmat.m'). Full suite passes.CI on dev is red right now for two reasons unrelated to this, so I added them here to get the checks green:
in/1/concore.paramsafter fix: read maxtime and params from in1 in concore.hpp #621. Same one-line fix as in fix: update s on ZMQ reads in Julia so unchanged() works #629.ubuntu-latestis now 26.04 and has no Python 3.9, so the test matrix fails to set up and cancels the rest. I pinned that job toubuntu-24.04, since we still support>=3.9.