Repository navigation
fix(mkconcore): copy concore_literal_eval.m and concore_literal_serialize.m for .m nodes - #649
Open
Siddhanthguptaa wants to merge 1 commit into
Conversation
…lize.m for .m nodes concore_read.m, concore_write.m, concore_initval.m and concore_default_maxtime.m call these helpers since the wire-format change, but mkconcore never copied them into out/src, so .m nodes got empty reads. Add them to the list of copied runtime files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648
mkconcore copies the MATLAB/Octave runtime into
out/srcfrom a fixed list. Since #575,concore_read.m,concore_write.m,concore_initval.mandconcore_default_maxtime.mcallconcore_literal_eval/concore_literal_serialize, which weren't in that list, so.mnodes got empty reads (the read's try/catch hides the "undefined function"). This adds the two files to the list, in the same style as the others. The windows, posix and docker build scripts already copysrc/concore_*.minto each node, so all three modes pick them up.Testing
test_build_command_m_node_copies_literal_helpersbuilds a.mnode and checks both files are inout/src; it fails on current dev and passes with this change.ruff check .andruff format --check .pass.ym(1): out of bound 0; with the helpers, controller and plant run the full loop to simtime 15.The MATLAB CI job runs with the repo root on the path, which is why it didn't catch this.