Skip to content

Keep DAG filter controls in sync on Back - #690

Merged
apollos-medic[bot] merged 2 commits into
mainfrom
medic/apo-16208-dags-filter-back
Oct 21, 2026
Merged

apollos-medic[bot] merged 2 commits into
mainfrom
medic/apo-16208-dags-filter-back

Conversation

@apollos-medic

@apollos-medic apollos-medic Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes APO-16208

The /dags filter is a plain GET form. If you pick a new Run state and submit, then press Back, the browser restores the previous page's form controls as you last left them, so the dropdown shows the unsubmitted no_runs while the URL and table are for the earlier filter. autoComplete="off" on the form stops that restore, so the controls follow the URL again.

Validation

  • Extended the DAG step in tests/dashboard.e2e.ts: filter failed, filter no_runs, go Back, and expect the URL and the Run state dropdown to both read failed. It failed on the first commit (observed no_runs) and passes with this change.

Proof plan

CI e2e covers the reported steps on fixture data.

Proof

Not run yet; available on request.

@apollos-medic
apollos-medic Bot requested a review from redreceipt as a code owner October 21, 2026 13:35
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bug-board Ready Ready Preview Oct 21, 2026 1:38pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

APO-16208

@mary-pr-poppins

Copy link
Copy Markdown

Please add screenshots to the PR description before requesting a review.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🟢 e2e: 7 passed

All 7 tests in 1 file
Test Time
🟢 tests/dashboard.e2e.ts · 7 passed 7.5s
🟢 dashboard navigation and no-secrets rendering 1.6s
🟢 preset and custom date windows survive navigation 864ms
🟢 review and DAG filters use URL state 1.5s
🟢 mobile navigation stays usable 2.3s
🟢 sign-in card has room around its action on phones and desktop 582ms
🟢 health is public, API and cron remain closed without authentication 347ms
🟢 legacy dashboard URLs still resolve 369ms

e2e 0.21.2 · 8.8s · web · run artifacts

@apollos-medic
apollos-medic Bot merged commit 333f921 into main Oct 21, 2026
4 checks passed
@apollos-medic
apollos-medic Bot deleted the medic/apo-16208-dags-filter-back branch October 21, 2026 14:05

This branch was successfully deployed

1 active deployment
Preview — 23c98411 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants