Repository navigation
Keep DAG filter controls in sync on Back - #690
Merged
Merged
Conversation
Closes APO-16208
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Please add screenshots to the PR description before requesting a review. |
🟢 e2e: 7 passedAll 7 tests in 1 file
e2e 0.21.2 · 8.8s · web · run artifacts |
redreceipt
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes APO-16208
The
/dagsfilter is a plain GET form. If you pick a new Run state and submit, then press Back, the browser restores the previous page's form controls as you last left them, so the dropdown shows the unsubmittedno_runswhile the URL and table are for the earlier filter.autoComplete="off"on the form stops that restore, so the controls follow the URL again.Validation
tests/dashboard.e2e.ts: filterfailed, filterno_runs, go Back, and expect the URL and the Run state dropdown to both readfailed. It failed on the first commit (observedno_runs) and passes with this change.Proof plan
CI e2e covers the reported steps on fixture data.
Proof
Not run yet; available on request.