Repository navigation
Keep review filter controls in sync after Back and reload - #691
Conversation
Closes APO-16205
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Please add screenshots to the PR description before requesting a review. |
🟢 e2e: 8 passedAll 8 tests in 1 file
e2e 0.21.2 · 10.6s · web · run artifacts |
|
@codex review this |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
✅ Approved — No issues found across any review domain.✅ All checks passed 🔒 Security: ✅ LGTMNo security issues; adding autoComplete="off" to a GET filter form introduces no new attack surface. 📋 Code Quality: ✅ LGTMNo maintainability issues; the fix is minimal, well-documented, and follows established patterns. Performance and Compliance skipped (lite review) Apollos Code Review · Claude · $0.05 |
nlewis84
left a comment
There was a problem hiding this comment.
Approved by AI Code Review — see the review comment above for details.
Closes APO-16205
On
/reviews, after applying author and reviewer filters and going Back to?author=&reviewer=&approved=1, the selects still showed the old people while the table was unfiltered. The browser restores form control values from history, which overrides the server-rendereddefaultValue. This addsautoComplete="off"to the reviews filter form, the same fix #690 made for the DAG filters.Validation
review filters stay in sync after Back and reloadfails onmain(Reviewer stillmichaelafter Back) and passes with this change. Same result reproducing the nightly explore steps on fixture data (Reviewer stillemery).npx e2e run tests/dashboard.e2e.ts --no-cache: 8/8 pass.npm run checkandnpm run buildpass.Proof plan
Open
/reviewson the preview, pick an author and reviewer, Filter, press Back, then reload, and confirm the selects show Everyone and Anyone.Proof
Not run yet; available on request.