Skip to content

Keep review filter controls in sync after Back and reload - #691

Merged
apollos-medic[bot] merged 1 commit into
mainfrom
medic/apo-16205-reviews-reload-stale-controls
Oct 21, 2026
Merged

apollos-medic[bot] merged 1 commit into
mainfrom
medic/apo-16205-reviews-reload-stale-controls

Conversation

@apollos-medic

@apollos-medic apollos-medic Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Closes APO-16205

On /reviews, after applying author and reviewer filters and going Back to ?author=&reviewer=&approved=1, the selects still showed the old people while the table was unfiltered. The browser restores form control values from history, which overrides the server-rendered defaultValue. This adds autoComplete="off" to the reviews filter form, the same fix #690 made for the DAG filters.

Validation

  • New e2e test review filters stay in sync after Back and reload fails on main (Reviewer still michael after Back) and passes with this change. Same result reproducing the nightly explore steps on fixture data (Reviewer still emery).
  • npx e2e run tests/dashboard.e2e.ts --no-cache: 8/8 pass. npm run check and npm run build pass.

Proof plan

Open /reviews on the preview, pick an author and reviewer, Filter, press Back, then reload, and confirm the selects show Everyone and Anyone.

Proof

Not run yet; available on request.

@apollos-medic
apollos-medic Bot requested a review from redreceipt as a code owner October 21, 2026 17:46
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bug-board Ready Ready Preview Oct 21, 2026 5:46pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

APO-16205

@apollos-medic
apollos-medic Bot enabled auto-merge (squash) October 21, 2026 17:46
@mary-pr-poppins

Copy link
Copy Markdown

Please add screenshots to the PR description before requesting a review.

@github-actions

Copy link
Copy Markdown

🟢 e2e: 8 passed

All 8 tests in 1 file
Test Time
🟢 tests/dashboard.e2e.ts · 8 passed 9.3s
🟢 dashboard navigation and no-secrets rendering 2.7s
🟢 preset and custom date windows survive navigation 911ms
🟢 review and DAG filters use URL state 1.5s
🟢 mobile navigation stays usable 2.3s
🟢 sign-in card has room around its action on phones and desktop 560ms
🟢 health is public, API and cron remain closed without authentication 389ms
🟢 legacy dashboard URLs still resolve 355ms
🟢 review filters stay in sync after Back and reload 633ms

e2e 0.21.2 · 10.6s · web · run artifacts

@redreceipt

Copy link
Copy Markdown
Member

@codex review this

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T18:09:26.405260Z 6dbd6f5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 6dbd6f5a8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nlewis84

Copy link
Copy Markdown

✅ Approved — No issues found across any review domain.

✅ All checks passed

🔒 Security: ✅ LGTM

No security issues; adding autoComplete="off" to a GET filter form introduces no new attack surface.

📋 Code Quality: ✅ LGTM

No maintainability issues; the fix is minimal, well-documented, and follows established patterns.

Performance and Compliance skipped (lite review)


Apollos Code Review · Claude · $0.05

@nlewis84 nlewis84 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by AI Code Review — see the review comment above for details.

@apollos-medic
apollos-medic Bot merged commit 5d7d939 into main Oct 21, 2026
4 checks passed
@apollos-medic
apollos-medic Bot deleted the medic/apo-16205-reviews-reload-stale-controls branch October 21, 2026 19:09

This branch was successfully deployed

1 active deployment
Preview — 6dbd6f5a Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants