Skip to content

Repository navigation

Keep DAG filter controls in sync on Back #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apollos-medic merged 2 commits into from
Oct 21, 2026
+9 −1
Merged

Keep DAG filter controls in sync on Back #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403029a
Keep DAG filter controls in sync on Back
apollos-medic[bot] Oct 21, 2026
23c9841
Stop Back restoring an unsubmitted DAG filter
apollos-medic[bot] Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/dags/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export default async function DAGs({
detail="Fresh fleet data requires Airflow credentials, Upstash Redis, and the scheduled refresh. Page requests never scan the production fleet."
/>
)}
<form method="get" className="filter-form">
{/* Stops the browser restoring an unsubmitted selection on Back. */}
<form method="get" className="filter-form" autoComplete="off">
<label>
Search DAGs
<input
Expand Down
7 changes: 7 additions & 0 deletions tests/dashboard.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ test("review and DAG filters use URL state", async ({
.selectOption({ value: "failed" });
await screen.getByRole("button", "Filter DAGs").tap();
await expect(browser).toHaveURL(/q=church.*state=failed/);
const runState = screen.getByLabel("Run state", { exact: true });
await runState.selectOption({ value: "no_runs" });
await screen.getByRole("button", "Filter DAGs").tap();
await expect(browser).toHaveURL(/state=no_runs/);
await browser.back();
await expect(browser).toHaveURL(/state=failed/);
await expect(runState).toHaveValue("failed");
});
test("mobile navigation stays usable", async ({ app, browser, screen }) => {
await browser.setViewport({ width: 390, height: 844 });
Expand Down
Loading