Repository navigation
Clarify the published performance results - #236
Merged
wallstop merged 1 commit intoOct 14, 2026
Merged
Conversation
The performance guide overstates the search result and describes a merged production defect as current. Readers cannot distinguish the recorded baseline from the missing post-fix validation. State that medians are below 100 ms while both recorded maxima exceed it. Distinguish the driver's three sizes from the two published sizes. Explain that the fixture-refresh timer excludes CreateAsset calls, verified against both the original baseline driver and current source. Link the merged type-only relevance fix and its open validation issue. All measurement and environment table lines match origin/main exactly. check:fast and all nine applicable check:gate steps pass. The strict MkDocs build passes; generated performance HTML contains the corrected claims. Unity validation does not apply to these prose-only changes. The host bridge remains unreachable, so no new measurement is claimed. Refs #114, #226, #228.
wallstop
force-pushed
the
docs-qualify-performance-baseline
branch
from
October 14, 2026 18:56
af25f69 to
a64469c
Compare
wallstop
added this pull request to stack #238
October 14, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: The performance guide overstates search latency and describes a merged defect as current.
What:
Refs #114, #226.
Note
Low Risk
Documentation-only edits to performance claims and gap notes; no runtime or test code changes.
Overview
Updates
docs/performance.mdso the published baseline matches what the harness actually measures and what the table proves.The how numbers are produced section now states that
PerfBaselineruns 100 / 1,000 / 10,000 assets while this page only publishes 100 and 1,000, and that fixture import times only the post-creationAssetDatabase.Refresh(not theCreateAssetloop).Search first results no longer implies a blanket sub-100 ms acceptance win: it calls out medians under 100 ms but maxima above it (e.g. 235.1 ms at 100 assets), and notes that five samples are not a worst-case or p95 guarantee.
Current gaps for 10k is rewritten to reference the merged #228 fix for #226, while making clear that a post-fix 10k run and full Unity test validation are still pending and the existing table is pre-fix.
Reviewed by Cursor Bugbot for commit a64469c. Bugbot is set up for automated code reviews on this repo. Configure here.