Skip to content

install: build on Redox #15276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Oct 13, 2026
Merged

install: build on Redox #15276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/uu/install/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use uucore::entries::{grp2gid, usr2uid};
use uucore::error::{FromIo, UError, UResult, UUsageError, strip_errno};
use uucore::fs::{are_files_identical, dir_strip_dot_for_creation};
use uucore::perms::{Verbosity, VerbosityLevel, wrap_chown};
#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
use uucore::safe_traversal::{DirFd, SymlinkBehavior, create_dir_all_safe};
#[cfg(all(feature = "selinux", any(target_os = "linux", target_os = "android")))]
use uucore::selinux::{
Expand Down Expand Up @@ -644,9 +644,9 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {

let sources = &paths.iter().map(PathBuf::from).collect::<Vec<_>>();

#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
let mut target_parent_fd: Option<DirFd> = None;
#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
let mut target_filename: Option<OsString> = None;

if b.create_leading {
Expand All @@ -666,6 +666,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
}

if let Some(to_create) = to_create {
#[cfg(all(unix, not(target_os = "redox")))]
let to_create_original = to_create;
let to_create_owned;
let to_create = match uucore::os_str_as_bytes(to_create.as_os_str()) {
Expand All @@ -684,7 +685,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
let dir_exists = to_create.exists() && metadata(to_create).is_ok_and(|m| m.is_dir());

if dir_exists {
#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
if b.target_dir.is_none()
&& sources.len() == 1
&& !is_potential_directory_path(&target)
Expand All @@ -711,7 +712,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
}
}

#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
{
// Use DEFAULT_MODE (0o755) for created directories - this matches GNU install
// behavior. The actual mode will be modified by umask at the kernel level.
Expand Down Expand Up @@ -754,7 +755,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
}
}
}
#[cfg(not(unix))]
#[cfg(any(not(unix), target_os = "redox"))]
fs::create_dir_all(to_create)
.map_err(|e| InstallError::CreateDirFailed(to_create.to_path_buf(), e))?;
}
Expand Down Expand Up @@ -789,7 +790,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
}

if is_valid_target(&target) {
#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
if let (Some(ref parent_fd), Some(ref filename)) = (target_parent_fd, target_filename) {
if b.compare && !need_copy(source, &target, b) {
return Ok(());
Expand All @@ -812,7 +813,7 @@ fn standard(mut paths: Vec<OsString>, b: &Behavior) -> UResult<()> {
} else {
copy(source, &target, b)
}
#[cfg(not(unix))]
#[cfg(any(not(unix), target_os = "redox"))]
{
copy(source, &target, b)
}
Expand Down Expand Up @@ -975,7 +976,7 @@ fn perform_backup(from: &Path, to: &Path, b: &Behavior) -> UResult<Option<PathBu
/// be consolidated because they use fundamentally different APIs:
/// - `copy_file_safe` uses fd-based `DirFd::open_file_at()` (openat syscall)
/// - `copy_file` uses path-based `OpenOptions::new().create_new().open()`
#[cfg(unix)]
#[cfg(all(unix, not(target_os = "redox")))]
fn copy_file_safe(from: &Path, to_parent_fd: &DirFd, to_filename: &std::ffi::OsStr) -> UResult<()> {
let from_meta = metadata(from)?;

Expand Down
Loading