Repository navigation
install: build on Redox - #15276
Merged
Merged
install: build on Redox#15276
Conversation
sylvestre
reviewed
Oct 12, 2026
| .map_err(|e| InstallError::CreateDirFailed(to_create.to_path_buf(), e))?; | ||
| #[cfg(any(not(unix), target_os = "redox"))] | ||
| fs::create_dir_all(to_create).map_err(|e| { | ||
| InstallError::CreateDirFailed(to_create_original.to_path_buf(), e) |
Contributor
There was a problem hiding this comment.
this changes the error message on windows too, intended? if so, please mention it in the commit message
Collaborator
There was a problem hiding this comment.
If this change was intentional it should be made in a separate commit at a minimum.
Contributor
Author
There was a problem hiding this comment.
I changed it to avoid an unused variable on Redox. Reverted: to_create_original is gated off Redox instead, so the message is the same everywhere.
Collaborator
|
1ac5cd1 compiles successfully locally: cargo clippy -q --target x86_64-unknown-redox -p uu_install --all-targets --all-features |
abendrothj
force-pushed
the
install-redox-build
branch
from
October 13, 2026 01:25
1ac5cd1 to
85dcfe3
Compare
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install used uucore's
safe_traversalunder#[cfg(unix)], but uucore doesn't build it on Redox, so install didn't compile there. On Redox it now takes the path-based code the non-Unix branches already have, as rm and du do. Nothing changes on other platforms; checked withcargo clippy --target x86_64-unknown-redox -p uu_install.There's no test because nothing in CI builds install for Redox: the Redox job is disabled, and
feat_os_unix_redoxdoesn't include install. Adding install to that feature set would guard it once the job is back on.#14772 touches the same code and will be rebased onto this.
Closes #15275