Repository navigation
🐛 fix(soft-rw): treat FreeBSD's EMLINK as a symlink refusal - #866
Merged
gaborbernat merged 2 commits intoOct 28, 2026
Merged
Conversation
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD, a soft reader/writer lock whose protocol tree another process swapped for a symlink kept reporting a transient refresh error from its heartbeat instead of a lost hold, so a holder there kept trusting a tree it no longer owned. 🐛 FreeBSD's
open(2)reportsEMLINKwhere POSIX specifiesELOOPwhenO_NOFOLLOWmeets a symlink in the final component, and the directory guard only knewELOOP,ENOTDIRand NetBSD'sEFTYPE.The guard that opens each protocol directory without following symlinks now counts
EMLINKamong the refusals it turns into a replaced-tree error, so the heartbeat classifies it as lost on FreeBSD as it does elsewhere. This is the FreeBSD counterpart of the NetBSD handling from #859 and closes the symlink group of failures in #864; the other items in that report stay open.