Repository navigation
chore: Add IDE components to pinned toolchain - #575
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
/cc @YuJuncen @iosmanthus |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iosmanthus, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
## What Add `tikv/client-rust` to the `STICKY_REPOS` list in the GCP Prow hook config so Prow keeps the `lgtm` label when new commits are pushed. ## Why In tikv/client-rust#575, merging `master` into the PR branch reset the `lgtm` label, so reviewers had to approve the PR again even though the PR changes were unchanged and only a base-branch merge was added. `tikv/client-rust` now follows the same sticky-lgtm behavior that is already enabled for the other TiKV repositories. ## Changes - `apps/gcp/prow/release/release.yaml`: add `tikv/client-rust` to the `STICKY_REPOS` env value. ## Notes The change takes effect after Flux reconciles the Prow release on the GCP cluster. Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Summary
rust-analyzercomponent to the pinned Rust 1.93.0 toolchain so VS Code can use the toolchain-compatible analyzer rather than warning about its newer bundled server.rust-srcso rust-analyzer has the matching standard-library source for navigation and analysis on a fresh installation.profile = "minimal"to avoid downloading the default profile's extra components (notably local Rust documentation) while explicitly retaining the project'srustfmtandclippycomponents.Fixes #574.
Verification
rustup show active-toolchain:1.93.0-aarch64-apple-darwinrustup component list --installed:rust-src,rust-analyzer,rustfmt, andclippypresentrustup run 1.93.0 rust-analyzer --version:rust-analyzer 1.93.0cargo check --lib --locked: passedcargo test --locked: passed (135 unit tests and 50 doctests; integration tests require their opt-in features and a TiKV cluster)The build still reports the existing unused-assignment warning in
src/common/errors.rs; this PR does not change Rust source.Summary by CodeRabbit