Repository navigation
refactor: rename Mela to Alba across code, scripts and docs - #5
Merged
Merged
Conversation
Move Kotlin packages from dev.mela to me.lvca.alba, rename Mela* classes, resources and the Room schema directory, and switch MELA_* environment variables, Sentry names and script helpers to ALBA_*/alba. Identifiers already stored on devices keep their old names: the catalog database, preference files, Keystore aliases, WorkManager unique work names and stored message codes. Work queued before the rename is mapped to the new worker classes, and an activity alias keeps the old launcher component so pinned home-screen icons survive the update.
Device tests share one app process. After the rename, AlbaAppTest sorts before AppSurfacesTest and leaves offline-copy transfers behind, so the "No transfers yet" empty state is no longer guaranteed.
CI runs device tests on two-core emulators with software rendering, so several tests failed intermittently, a different one each run: - Raise 10-second waits to a shared 30-second CI_WAIT_MS. Repository edits queue behind catalog refreshes and could exceed 10 seconds. - Replace assertions made right after navigation, activity recreation, the viewer transition or a dialog opening with waitUntilDisplayed.
A restored LazyGridState only holds an index. When the grid is first measured against fewer items than that (another tab's results still showing, or a catalog that has not loaded), the index is clamped and the scroll resets to the top. On slow CI emulators this made GalleryNavigationTest lose the library position after recreate(). Remember the first visible photo id and offset per grid, save it, and re-apply it once the photo is present. A user scroll cancels the pending restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finishes the move from the old Mela name to Alba:
dev.mela.*→me.lvca.alba.*, matching the app ID;Mela*classes, resources, theme and Room schema directory renamed.MELA_*environment variables, script helpers and Sentry operation names →ALBA_*/alba.; default Sentry project slug is nowalba-android(renamed in Sentry).thisislvca/alba.The app ID (
me.lvca.alba) is unchanged.Kept on purpose
Identifiers already stored on testers' phones keep their old names, each marked with a comment:
mela-catalog.db,mela-onboarding,mela_diagnostics,mela_icloud_sessionpreferencesmela_icloud_session_v1andmela_upload_checkpoints_v1StoredMessagecodes / legacy textTwo Android-side names also survive updates:
LegacyWorkerFactorymaps queueddev.mela.app.*Workerjobs to the renamed classes (unit-tested).activity-aliaskeepsdev.mela.app.MainActivityas the launcher component so pinned home-screen icons keep working.Historical references (the
mela-archiveCI guard, the retired certificate note in RELEASING.md, the pinned review-video source link) are left as they are.Verification
./gradlewCI build, unit tests and lint: pass. Script tests: 18/18.AppSurfacesTest.utilitySheetsAndProfileScrollUnderGestureArea,GalleryNavigationTest.libraryLeadsWithPhotosAndDestinationsPreserveTheirOwnState) pass when run alone on both this branch andmain, so they look order-dependent rather than rename-related.