Repository navigation
test: wait for UI and repository work on slow CI emulators - #6
Merged
Merged
Conversation
CI runs device tests on two-core emulators with software rendering, so several tests failed intermittently, a different one each run: - Raise 10-second waits to a shared 30-second CI_WAIT_MS. Repository edits queue behind catalog refreshes and could exceed 10 seconds. - Replace assertions made right after navigation, activity recreation, the viewer transition or a dialog opening with waitUntilDisplayed.
thisislvca
added a commit
that referenced
this pull request
Oct 17, 2026
CI runs device tests on two-core emulators with software rendering, so several tests failed intermittently, a different one each run: - Raise 10-second waits to a shared 30-second CI_WAIT_MS. Repository edits queue behind catalog refreshes and could exceed 10 seconds. - Replace assertions made right after navigation, activity recreation, the viewer transition or a dialog opening with waitUntilDisplayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5. Device tests fail intermittently on CI, with a different test failing each run. This makes them wait properly on CI's slow emulators.
Cause
CI runs on two-core Pixel 2 emulators with software rendering. Two patterns time out there:
DefaultGalleryRepository.edit, which waits for any catalog refresh in progress. CI timings for the failing tests were about 14 s, which fits a 10 s timeout plus setup. Failing tests:DemoReviewGapsTest.invitationAccept…andGalleryCompletionTest.cloudTrash….recreate(), the viewer's shared-element transition, or anAlertDialogwindow opening. Failing tests:GalleryNavigationTest.libraryLeads…(also fails onmain),AlbaAppTest.androidBackClears…andIncomingMediaActivityTest.sharedPhotoCanBeImported….Change
CI_WAIT_MS = 30s, replacing every 10-secondwaitUntilin the app device tests (19 call sites).waitUntilDisplayed(matcher)helper, used at the bare assertions listed above.No production code changes. Disabling animations was considered and rejected, because some tests check intermediate animation frames.
Verification