Repository navigation
feat: deliver prepared shared data to Before/After snapshots - #49
Conversation
Signed-off-by: Kent Huang <kent@infuseai.io>
|
Independent review record (read-only, per REVIEWER_GUIDELINES.md): fresh Standards reviewer — APPROVE; fresh Spec reviewer — APPROVE. Scope: PR 1 shared-data delivery files at commit 6406504 on base 7f615f0. Earlier material findings were fixed before these approvals. Live verification pending (DRC-4916). |
Behavior Diff ·
|
Behavior Diff ·
|
|
Post-publication CI observation at head 6406504: Format and Unit passed. The existing dogfood workflow has one failed comparison for plugin/skills/behavior-diff/SKILL.md. Its uploaded result.json reports runner_exit=0, no report, 0/3 complete trials on either side, and extraction unavailable. The artifact does not establish the underlying cause; this is not a successful behavioral comparison or evidence that the new helper failed. The dogfood Action selected core revision 854ae1b. No automatic rerun or production fix was made. Separately requested private live verification is in progress: one single-file case exercises the new helper; a second multi-file case is an explicitly approved historical control, not helper acceptance. Private inputs/reports will not be posted here. |
|
Live-verification follow-up for unchanged head 6406504: both requested private comparisons completed once (3 Before + 3 After + extraction each). The new-helper case used dated Opus 4.5 with high reasoning, delivered a nonempty external shared-data overlay matching frozen originals, and reproduced an unmet After requirement in raw evidence that the automatic report missed. The owner-approved multi-file control used Sol 6.1 high; its prior output-duplication failure did not reproduce, and it is not new-helper acceptance. Actual assistant-event model identities were checked. The PR body now records sanitized results and the unresolved separate dogfood report-generation failure. No product changes or retries followed these runs; all private inputs and reports remain local. PR remains draft. |
|
CI diagnosis follow-up for job 117886131286 (no paid rerun): found a confirmed evidence-collection defect in Action commit 32f1bc3bf8c8a2588a0cca5aca44d9cee4de7b93. scripts/execute.py::_single_run accepts exactly one entry under the run home. I executed the source-extracted collector against synthetic valid reports/grades: one run reports complete with 3/3 per side; adding a second empty nested-run directory reproduces the exact saved failure signature (exit 0, no report, 0/3 both sides, extraction unavailable), while the outer report still exists. Nested comparisons are a reachable explanation when dogfooding the Behavior Diff skill: trial subprocesses inherit BEHAVIOR_DIFF_HOME and may invoke the runner. This is a strong candidate for this job, not proof that nesting occurred: runner stdout/stderr and private run trees were discarded, so the uploaded result cannot distinguish ambiguous run selection from absent output. The 0/3 counts are collector defaults, not proof that no trials executed. Also verified core revision 854ae1b is the merge of PR head 6406504 into base 7f615f0, not an old bundled core. Recommended correction: collect the explicitly identified outer run, and preserve bounded sanitized collection diagnostics before cleanup. No repository changes or workflow retry performed. |
|
Diagnosis cross-check: fetched behavior-diff.sh from the exact CI core revision 854ae1b and confirmed it is byte-identical to the runner inspected locally. Also exercised the same source-extracted collector with an empty run home: it produces the identical failure signature. Therefore the saved result is consistent with ambiguous nested runs OR missing output and does not identify which occurred. Nested execution remains a reachable hypothesis, not a confirmed event. No model calls or code edits were made. |
|
Correction review round (head 6406504 plus unpublished local fix): Spec reviewer APPROVE. Standards reviewer REVISE for an existing PR1 edge case: prepare_shared.py treats BEHAVIOR_DIFF_HOME="" as cwd rather than using the default home, unlike the runner/hooks. Both reviewers accept trial-local storage isolation and opt-in real nested-run regressions. The empty-home fallback will be corrected and regression-tested before publication; full re-review and corrected-head dogfood success remain required. Nested smoke failed before (3 root runs rather than1 for both hosts), then all30 manual/boundary checks passed with isolation. No merge yet. |
Signed-off-by: Kent Huang <kent@infuseai.io>
|
Final correction review: independent Standards and Spec reviewers both APPROVE head 2e49baa against base 7f615f0. All material findings resolved: trial-local homes prevent nested-run contamination; empty home overrides retain default hook-baseline semantics. Both regression paths demonstrated failing-before/passing-after. All31 boundary/manual smoke tests passed, including actual nested shipped runners through fake Claude/Codex; required deterministic suites, formatting, syntax and whitespace checks passed. Scope audit: no Action API, report redesign, generator or multi-file feature added. Fresh dogfood will use this corrected branch/core revision and the failed SKILL.md selection. Original incident cause remains unproven because prior logs were deleted. No merge until fresh collection/publication and CI pass. |
|
Merge gate satisfied for head 2e49baa (base 7f615f0): both independent read-only reviewers APPROVE; final31 boundary/manual smoke checks and required suites passed; Format and Unit passed. Fresh dogfood run https://github.com/spacedock-dev/behavior-diff/actions/runs/39213095873 used this exact corrected core/head and succeeded through publication. Inspected uploaded result.json: complete, Before3/3, After3/3, extraction complete, runner_exit0, error null, report_available true. No unresolved material review findings. The original historical nesting cause remains unproven, but the reproduced isolation defect is fixed and the current CI report path is verified. Merging under the owner request. |
Summary
PR 1 of the intention-driven preparation plan (DRC-4916): safely deliver prepared shared scenario data into real Before/After trial snapshots.
prepare_shared.pyand one canonical shared-data delivery reference, integrated into the skill without public runner interface changes.Not included: automatic scenario/data generation (PR 2), multi-file delivery support, report assessment/UI changes.
Verification
Requested private live verification
Two frozen historical scenarios were rerun once, without scenario regeneration or retries. Each used three Before and three After trials plus one extraction. Actual assistant-event model identities were checked, not merely command arguments.
anthropic/claude-opus-4-5-20251101, high reasoning, OMP. External shared data and historical instructions were split and reassembled through the new helper; resulting content/executable bits matched the frozen originals. All six trials completed. Raw evidence reproduced an unmet After verification requirement; the automatic report did not identify it.openai-codex/gpt-6.1-sol, high reasoning, OMP. The owner approved using the existing private multi-file harness because this case exceeds PR 1's single-file contract. All six trials completed; its previously observed output-duplication failure did not reproduce. This is not acceptance evidence for the new helper.Extraction was separately invoked using each historical condition's same pinned model. Inputs, traces and reports remain private; no private source excerpts or report artifacts are attached. These runs do not prove PR 2 generation or automatic assumption validation.
CI failure resolved on the corrected head
The original dogfood job failed to collect a report. A deterministic nested-run reproduction demonstrated parent run-directory contamination; trial-local storage fixes that path. An independent review also found and verified the empty-home fallback correction. Both regressions failed before their fixes and passed afterward.
Fresh dogfood run 39213095873 used head/core
2e49baa409d18cec1c16c6dde22e656297f077dc. Its uploaded result confirms status complete, 3/3 Before and 3/3 After, extraction complete, runner exit 0, no error, and report available. Prepare, run, and publish all succeeded; Format and Unit also passed. Both independent reviewers approved this corrected scope.The original logs were deleted, so nesting remains an unproven explanation of that historical occurrence. The isolation defect is reproduced and fixed, and current CI successfully collects/publishes its report. The private real-case results above predate the isolation correction; they were not rerun.
Linear: DRC-4916