Repository navigation
Prepare scenarios and test data from instruction-change intent - #50
Conversation
Signed-off-by: Kent Huang <kent@infuseai.io>
Independent AI review recordReviewed base: The following are independent read-only AI subagent reviews, not human GitHub approvals. Reviews covered all six changed files. Reviewers did not run tests, formatters or live models; the implementing agent supplied verification and reviewers inspected evidence. Round 1 — REVISE (Standards and Spec)Both reviewers identified the same P2 finding: historical preparation must move to fresh context before deriving purpose when the orchestrator already knows later outcomes. Merely disclosing hindsight did not satisfy the accepted plan. Corrected the canonical skill and reference to require isolation, specify contemporary inputs, and stop when isolation is unavailable. Selection-bias disclosure remains required. Decisions required: none. Optional suggestions: none. Scope audit: no new runtime infrastructure, public schema, simulator or report redesign; affected wording-only assertions removed rather than repinned. Round 2 — APPROVE source (both reviewers)Both reviewed the complete corrected scope and confirmed the historical-isolation finding resolved. They also approved native-status/terminal-event checks in raw assessment. Source approval did not waive the then-blocked Claude authentication/live gate. Codex generation, actual input consumption and raw explanation were inspected; its provider-capacity interruption remained unassessable, not an instruction failure. Material findings, decisions and optional suggestions: none. Scope remained the approved PR 2 boundary. Round 3 — APPROVE source and bounded two-host evidence (both reviewers)After native Claude authentication was restored, both reviewed its generated preparation, actual six-trial snapshot audit, model records and raw explanation. The bounded AC1–AC10 gate is satisfied across both hosts. The permission-note correction and recommendation-versus-payment distinction are explicitly preserved. No general reliability, causal improvement, permission-enforced containment, or live historical-isolation coverage is claimed. Material findings, decisions and optional suggestions: none. No unauthorized mechanisms or scope changes. Publication and merge were not authorized by reviewer approval; the owner subsequently requested this draft PR, not a merge. Verification supplied by the implementing agentRequired deterministic suites passed, including 31 shared-data boundary/runner-smoke checks. Repository shfmt/Ruff and changed-shell syntax/ShellCheck passed; final No saved report was rewritten. Private artifacts were not committed. The source-version chronology and remaining evidence limits are retained in the implementation plan and PR description. Published head matches the approved source changes and factual acceptance record. CI has started; this comment does not claim CI completion. |
Behavior Diff ·
|
|
Pre-merge check on head c5ca36e: Format and Unit passed, but Behavior Diff run 39217533591 failed its final gate. Downloaded result.json records 3/3 Before and 3/3 After complete, runner_exit 0, report_available true, status partial, extraction unavailable. Error: Decision extraction was unavailable; the report shows trial evidence without a decision diff. The job log and published bundle do not contain the underlying extractor failure diagnostics, so this is not yet attributable to provider capacity, authentication, malformed extraction, or the instruction change. No models were rerun and no code was changed. Earlier local acceptance remains valid but does not turn this CI gate green. Merge paused pending resolution or an explicit owner decision on this newly disclosed limitation. |
Review round 4 — CI extraction correction (not yet published)Reviewed base: Finding and dispositionThe failed dogfood run retained six graded-complete trials and reports, but no usable extraction. The Action did not retain the original extraction exception. A conservative reconstruction from the retained commands, final answers, frozen instruction diff and fixed extraction instructions requires 134,036 bytes, excluding all tool-return text, purpose goals and style guidance. Claude extraction passed the whole prompt as one argv argument. Linux with 4 KiB pages limits one argument to 131,072 bytes, including its terminator. A network-disabled Linux smoke using the actual No evidence trimming, retries, model changes, report-schema changes, or CI bypass. No changes to the external Action repository are needed. Independent AI review
These are independent AI subagent reviews, not human GitHub approvals. Reviewers ran no tests or model calls. GatesFailing-before/passing-after Linux transport smoke completed. Full deterministic checks are running. Code remains unpublished; actual corrected CI has not run. Merge remains blocked until that gate passes. The first failed run and its evidence remain preserved. |
Signed-off-by: Kent Huang <kent@infuseai.io>
Review round 5 — published correction and final source approvalBase: Both independent AI reviewers re-inspected the complete latest scope after the plan bookkeeping correction:
Scope audit: the existing Claude extractor now receives the unchanged prompt on stdin; no new dependency, schema, model, retry, trimming policy, public CLI mode, or gate bypass. The plan distinguishes published PR2 and the transport correction from deferred report redesign. These are AI subagent reviews, not submitted human approvals. Verification completed by the primary agent
The actual corrected dogfood run is now running against this exact head, with three trials per side and unchanged configured roles ( |
Post-review evidence limitation — original dogfood scenarioReviewed head remains The original failed run's generated task directed every trial to shared Both independent Standards and Specification reviewers inspected this evidence and retained APPROVE, with no material findings, new decisions required, or additional mechanism warranted. This is an existing outside-worktree isolation limitation, not introduced by PR2; separate directories are not a filesystem sandbox. Dedicated native-host preparation smoke and snapshot audits remain separate acceptance evidence. The contaminated records still establish prompt size; their contents' validity does not remove the demonstrated Linux transport defect. A green corrected dogfood run will establish pipeline operation only—not automatically independent causal effectiveness. Its evidence will be checked on its own merits. No sandboxing or task-drafter redesign is silently included in PR2. |
Final pre-merge gate — passedApproved head: Corrected dogfood CI succeeded in prepare, run and publish. Its retained Both independent AI reviewers inspected the final result and report limitations and retained APPROVE, with no material findings, decisions required, or suggestions. No additional mechanism or scope expansion is required. Source has not changed since their approval. Limits retained, not waived
The user requested merge and explicitly required fixing, not bypassing, the failed gate. That operational gate is now satisfied. Merging the reviewed head without further code changes. |
What changes
Behavior Diff can now start from a local instruction edit without asking the user for an incident or prepared evaluation dataset. The skill derives the intended change and behavior to preserve, selects observable capabilities, writes a neutral task, and prepares coherent ordinary and boundary-case data. It preflights and freezes the inputs before handing them to PR #49’s existing delivery helper.
After execution, the skill assesses each case from raw evidence: was the relevant condition reached, was the intended outcome supported, and did the attempt actually complete? It explains disagreements with the automatic report instead of silently changing that report. Historical preparation must use an isolated context when later outcomes are already known.
This is PR 2 of the intention-driven preparation plan. Preparation remains agent-owned; there is no new generator service, public schema, simulator framework, or runner API. README and architecture describe the new workflow. Wording-only assertions were removed rather than repinned; deterministic runtime contracts remain.
Verification
git diff --checkpassed.gpt-6.1-soltrials andgpt-6-lunaextraction. Five of six attempts completed with unchanged correct decisions; one Before attempt stopped on provider capacity and remains unassessable. No trial retry or model substitution.claude-opus-5-5, with default Sonnet extraction. Both versions recommended the same three invoices and withheld four questionable ones. No payment occurred; no improvement attributable to the edit is claimed.Limits and deferred work
Tracking: https://linear.app/recce/issue/DRC-4917
Plan:
plans/2026-10-19-intention-driven-preparation-implementation.mdDraft for review; do not merge implicitly.