[kalverra]

Why

Remote executable ClientRequest read beholder.GetEmitter() and durableemitter.GlobalEmit directly when emitting its transmission-schedule event, serializing the test that asserts on it. This PR injects both sinks from boot config instead, so callers and tests can supply their own.

Notes

• Defaults stay late-bound: with no option, the request resolves beholder.GlobalEmitter() (which delegates at emit time) and durableemitter.GlobalEmit, so production emission is unchanged.
• The injected durable func is the same durableemitter instance Setup installs globally, so events are not emitted twice.
• NewLauncher is now variadic (opts ...LauncherOption) rather than taking another positional arg; boot passes capabilities.WithDurableEmit.

Changes

Durable sink flow, request construction to emit:

flowchart LR
  B[cre.Opts.DurableEmit]:::new -->|"capabilities.WithDurableEmit"| L[NewLauncher]:::new
  L -->|"executable.WithDurableEmit"| C[NewClient]:::new
  C -->|Execute| R[NewClientExecuteRequest]:::new
  R -->|clientRequestConfig| E[emitTransmissionScheduleEvent]:::new
  E -->|nil default| G[beholder.GlobalEmitter / durableemitter.GlobalEmit]
  classDef new fill:#d4f8d4,stroke:#2da44e

Loading

ClientRequestOption targets a small config struct

• Options configure clientRequestConfig instead of a throwaway ClientRequest; the struct flows into newClientRequest and emitTransmissionScheduleEvent.
• NewClientExecuteRequest keeps its existing call sites: options are variadic.

“Executes full schedule” test now runs in parallel

• Swaps the process-global beholdertest.NewObserver for an injected NewRecorder, so parallel siblings cannot cross-talk.
• Test_Client_Execute_InjectsDurableEmit asserts the client forwards its durable func, and starts the client via servicetest.Run so cleanup joins the request goroutines.

Requires

#23971 (workflows/events Emitter pattern and chainlink-common bump)

Supports

#23973 (meters layer)

Deployment Validation Steps

Run a node with remote capabilities and confirm transmission-schedule events still reach beholder; no schema or entity changes expected.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs

[kalverra]

PR Triage · Risk Medium · Complexity Low

Suggests 1 approval, including one from an owner. Suggested reviewers: @bolekk, @jmank88.

	Level	Why
Risk	Medium	core/services/cre/cre.go is a hotspot: 16.09 recent commits in 90d (cut 8.21) and max function cognitive complexity 51 (limit 15)
Complexity	Low	No metric or rule reached a threshold

Start Review Here

1. core/services/cre/cre.go:407-536 Services.newRegistrySyncer — hotspot file · function complexity 25
2. core/capabilities/remote/executable/request/client_request.go:127-163 NewClientExecuteRequest — logic added 3 · function complexity 5
3. core/capabilities/launcher.go:131-202 NewLauncher — logic added 1 · function complexity 7
4. core/capabilities/remote/executable/client.go:86-99 NewClient — logic added 1 · function complexity 1

Visualizations

Score map

flowchart LR
  R["Risk: Medium"]
  rs["1 signal → floor Medium"]
  s0["hotspot core/services/cre/cre.go"] --> rs
  rs --> R
  C["Complexity: Low"]
  cn["no rule or threshold applied"] --> C
  RT["Suggests 1 approval · one from an owner"]
  R --> RT
  classDef low fill:#dafbe1,stroke:#1a7f37,color:#1f2328;
  classDef medium fill:#fff8c5,stroke:#9a6700,color:#1f2328;
  classDef high fill:#ffebe9,stroke:#cf222e,color:#1f2328;
  class R medium;
  class C low;

Loading

Change shape

pie title Change shape
    "Tests" : 558
    "Source" : 572

Loading

— distributed across 6 files

Files: 6 changed

File	Risk	Complexity	Why
core/capabilities/launcher.go	Low	Low
core/capabilities/remote/executable/client.go	Low	Low
core/capabilities/remote/executable/client_test.go	Low	Low
core/capabilities/remote/executable/request/client_request.go	Low	Low
core/capabilities/remote/executable/request/client_request_test.go	Low	Low
core/services/cre/cre.go	Low	Low

Why these reviewers

Reviewer	Share	Last commit
@bolekk	25%	2026-10-22
@jmank88	16%	2026-08-25

Others who know this code: amit-momin 12%, dhaidashenko 10%, cedric-cordenier 6%.

Ranked by commits to the changed files in the 360 days before the head commit; newer commits count more. Requested everyone with at least 20% of the score, up to 4. Added 1 reviewer below that to reach 2 reviewers. Excluded the PR author, @kalverra. Considered only current members of the repository's organization, excluding 1 candidate.

Metrics and policy

Metric	PR value	Scale	Medium at	High at
logic added (cognitive delta)	5	[██░░░░│░░░░░░░░░░░░│]	15	45
syntax change (AST delta)	1,130	[██████████████░░░░░│]	1,600	—
new code size (Kolmogorov delta)	1,076	[█████████████░░░░░░│]	1,600	—
most complex function (max function cognitive complexity)	54	[███████████████░░░░│]	70	70

Risk signals: change spread ○ · subsystems ○ · hotspot ● · blast radius ○ · author familiarity ○ · floor Medium

pr-triage v0.0.0-20261022163026-983b86af43a2+dirty · policy d03c412

---

_{What is this? · How is this calculated?}

[Copilot]

🟡 Changes recommended

The new forwarding test needs client lifecycle cleanup to prevent an outbound request goroutine from logging after test completion.

1 open issue

• Use servicetest.Run to join outbound request goroutine · New

What changed in this PR

Extends the emitter-injection work from #23971 to remote executable requests, preserving late-bound global defaults while allowing transmission-schedule events to use the boot-configured durable emitter.

Changes:

• Adds emitter options to clients and requests, applied before schedule events are emitted.
• Threads the durable emitter from CRE through the launcher to remote clients.
• Uses an isolated recorder for the parallel schedule test and adds durable-forwarding coverage.

File	Description
core/​services/​cre/​cre.go	Passes the configured durable emitter to the launcher.
core/​capabilities/​remote/​executable/​request/​client_request.go	Adds injectable event sinks with global defaults.
core/​capabilities/​remote/​executable/​request/​client_request_test.go	Isolates schedule-event recording and enables parallel execution.
core/​capabilities/​remote/​executable/​client.go	Forwards client emitter options to requests.
core/​capabilities/​remote/​executable/​client_test.go	Adds durable-emitter forwarding coverage.
core/​capabilities/​launcher.go	Supplies the durable emitter to remote executable clients.
core/​capabilities/​launcher_test.go	Updates launcher construction for the new parameter.
core/​capabilities/​launcher_offchain_method_configs_test.go	Updates launcher construction while retaining default emission.

_{Review effort: Balanced}

[cl-sonarqube-production]

Quality Gate passed

Issues
2 New issues
25 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube