[kalverra]

Why

Layer 1 of the beholder emitter-injection stack (DX-5066): jobspec, node_platform, and shell tests asserted on emissions via beholdertest.NewObserver, which swaps the process-global client and blocks t.Parallel(); this PR injects per-test beholdertest.Recorder emitters instead, with late-binding defaults so production behaviour is unchanged.

Notes

• Bumps chainlink-common to the Phase 0 version providing Recorder / GlobalEmitter / NewLabelerWithEmitter (go.mod).
• Production changes are late-binding only: NewApplication passes beholder.GlobalEmitter() (resolved at emit time) instead of the construction-time beholder.GetEmitter().
• TestShell_BeholderLifecycle still installs a real client globally via initGlobalsOnce and never restores it; harmless now that no core test asserts on the global.

Changes

How emitters resolve after this PR:

flowchart LR
  A[NodePlatform / jobspec reporter / Shell] --> E["cfg.Emitter / s.beholderEmitter()"]
  E -->|nil: production| GE["beholder.GlobalEmitter (late-bound)"]:::new
  E -->|injected: test| R[beholdertest.Recorder]:::new
  classDef new fill:#d4f8d4,stroke:#2da44e

Loading

NodePlatform*Config.Emitter fields

• Both services default a nil Emitter to beholder.GlobalEmitter() at construction; the dead in-loop GetEmitter() fallbacks are deleted.

Shell emits through its own client's emitter

• beholderEmitter() returns the Shell's configured emitter, else GlobalEmitter(); EmitNodeConfig labels through it, so multiple Shells in one process no longer share the first one pinned as global.

jobspec tests inject a recorder

• newTestReporter returns the service with its recorder; TestEngine_Execution, emit_test.go, and cl_job_info_test.go drop NewObserver for NewRecorder + t.Parallel().

Merge Danger

	Rating	Why
Revert	🟡 minor	Single commit, but the go.mod bump and new symbols are load-bearing for upstack 23971–23973.
Blast radius	🟢 small	Defaults preserve behaviour; only test wiring and late-binding changed.

Requires

chainlink-common#2458 (beholdertest.Recorder, beholder.GlobalEmitter, custmsg.NewLabelerWithEmitter)

Supports

#23971 · #23972 · #23973 (rest of the DX-5066 beholder stack)

Deployment Validation Steps

Run a node locally with telemetry enabled and confirm node config and job info still reach beholder (collector output, or the debug log node configuration emitted through beholder).

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[github-actions]

👋 kalverra, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs

[Copilot]

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

What changed in this PR

Injects per-test Beholder emitters for jobspec, node-platform, and shell code while preserving production behavior through late-bound global emitters.

Changes:

• Adds configurable emitter injection.
• Replaces global observers with parallel-safe recorders.
• Updates shared dependencies and checksums.

File	Description
system-tests/​tests/​go.sum	Updates dependency checksums.
system-tests/​tests/​go.mod	Updates dependencies.
system-tests/​lib/​go.sum	Updates dependency checksums.
system-tests/​lib/​go.mod	Updates dependencies.
integration-tests/​load/​go.sum	Updates dependency checksums.
integration-tests/​load/​go.mod	Updates dependencies.
integration-tests/​go.sum	Updates dependency checksums.
integration-tests/​go.mod	Updates dependencies.
go.sum	Updates dependency checksums.
go.mod	Updates shared dependencies.
deployment/​go.sum	Updates dependency checksums.
deployment/​go.mod	Updates dependencies.
core/​services/​workflows/​v2/​engine_test.go	Uses an injected recorder.
core/​services/​nodestatusreporter/​jobspec/​job_spec_reporter_test.go	Uses per-test recorders.
core/​services/​nodestatusreporter/​jobspec/​events/​emit_test.go	Uses recorder-based assertions.
core/​services/​nodestatusreporter/​jobspec/​cl_job_info_test.go	Uses recorder-based assertions.
core/​services/​chainlink/​node_platform.go	Adds configurable emitters with global fallback.
core/​services/​chainlink/​node_platform_test.go	Injects recorders into tests.
core/​services/​chainlink/​application.go	Uses the late-bound global emitter.
core/​scripts/​go.sum	Updates dependency checksums.
core/​scripts/​go.mod	Updates dependencies.
core/​cmd/​shell_test.go	Uses an injected recorder.
core/​cmd/​shell_local.go	Resolves the shell-specific emitter.

🧠 Review effort: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
6 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube