Repository navigation
Rollup of 19 pull requests - #165548
Closed
JonathanBrouwer wants to merge 58 commits into
Closed
Rollup of 19 pull requests#165548JonathanBrouwer wants to merge 58 commits into
JonathanBrouwer wants to merge 58 commits into
Conversation
This reduces the amount of special casing #[no_mangle] needs in the rest of the compiler.
#[link_ordinal] is not compatible with #[link_name] and items in extern blocks now have an implicit #[link_name] with the item name. Alternatively it would be possible to suppress the error message for this implicit #[link_name].
Co-authored-by: Ralf Jung <post@ralfj.de>
This ensures the name it is referenced with from object files matches the name that it is imported as in an import library.
… faster than Vec::retain_mut
```
error[E0107]: missing generics for struct `a::Foo`
--> $DIR/impl-block-missing-const-generics.rs:6:10
|
LL | impl Foo {}
| ^^^ expected 1 generic argument
|
note: struct defined here, with 1 generic parameter: `AHA`
--> $DIR/impl-block-missing-const-generics.rs:4:12
|
LL | struct Foo<const AHA: usize>{}
| ^^^ ----------------
help: add missing generic argument
|
LL | impl<const AHA: usize> Foo<AHA> {}
| ++++++++++++++++++ +++++
```
Previously we only suggested `Foo<AHA>` without the `impl<const AHA: usize>`.
``` error: the constant `N` is not of type `usize` --> $DIR/const-in-impl-fn-return-type.rs:12:32 | LL | fn func<const N: u32>() -> [(); N]; | ------------ ^^^^^^^ expected `usize`, found `u32` | | | found this const parameter | = note: the length of array `[(); N]` must be type `usize` ```
``` error: the constant `B` is not of type `usize` --> $DIR/check_const_arg_type_in_free_alias.rs:15:30 | LL | type ArrLen<const B: bool> = [(); B]; | ------------- ^^^^^^^ expected `usize`, found `bool` | | | found this const parameter | = note: the length of array `[(); B]` must be type `usize` ```
```
error: the constant `N` is not of type `usize`
--> $DIR/bad-subst-const-kind.rs:8:26
|
LL | impl<const N: u64> Q for [u8; N] {
| ------------ ^^^^^^^ expected `usize`, found `u64`
| |
| `N` defined here
|
= note: the length of array `[u8; N]` must be type `usize`
```
Per the style team FCP in rust-lang#152760, remove the prescription requiring an explicit ABI on extern items so formatters preserve the ABI as written in the AST and defer missing-ABI diagnostics to language lints.
rustbot
added
the
WG-trait-system-refactor
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
Rollup of 19 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…uwer Rollup of 19 pull requests Successful merges: - #164784 (Introduce OptimizationObjective and fix the entry shim's size attributes) - #165037 (Drop array elements in order after a partial move) - #165078 (Use the `2.38` binutils version in CI) - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - #163284 (feat(Reborrow): Allow multiple lifetimes) - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present) - #165222 (Anonymize inner binders when checking refining) - #165335 (Fallible type ops) - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165494 (fix Miri ICE on exit with () return type) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165512 (Fix warnings for the L4Re targets) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165518 (style-guide: Remove ABI explicitness prescription for extern items) - #165519 (Update books) - #165534 (rename MIR_borrow_checking timing scope to less confusing name)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for f53a285 failed: CI. Failed job:
|
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…uwer Rollup of 6 pull requests Successful merges: - #165495 (rustdoc: Improve performance by skipping unneeded intermediate JSON serializations) - #165523 (remove stability attributes from intrinsics) - #165034 (allow configuring rustc_perf's path for out-of-tree uses of rustc_perf) - #165373 (use correct span for lifetimes with attributes) - #165539 (lint: do not emit unreachable_code on become with diverging callee) - #165556 (rustc_config: Replace `Option` with a custom enum for `--jobs` options) > [!WARNING] > This rollup conflicts with pending auto build #165548 and may need to be recreated if the pending build succeeds.
Member
Author
|
@bors try jobs=dist-powerpc64-linux-gnu |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
Rollup of 19 pull requests try-job: dist-powerpc64-linux-gnu
Member
Author
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing. This pull request was unapproved. |
Contributor
|
PR #164784, which is a member of this rollup, changed its commit SHA to This rollup was closed. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
2.38binutils version in CI #165078 (Use the2.38binutils version in CI)constparameter to provide more context and more accurate suggestion #164775 (Tweak output on misusedconstparameter to provide more context and more accurate suggestion)use<...>suggestion whenimpl Traitparams are present #165194 (name elided lifetimes inuse<...>suggestion whenimpl Traitparams are present)Vec::retain_unstabledocs to say that this method is generally faster thanVec::retain_mut#165448 (UpdateVec::retain_unstabledocs to say that this method is generally faster thanVec::retain_mut)#[non_exhaustive]on enum variants with default field values #165505 (DFV: Reject#[non_exhaustive]on enum variants with default field values)WhereEqPredicateandScopeIdtypes #165514 (Remove unusedWhereEqPredicateandScopeIdtypes)r? @ghost
Create a similar rollup