Rollup of 6 pull requests by JonathanBrouwer · Pull Request #165563 · rust-lang/rust

JonathanBrouwer · 2026-11-06T20:11:34Z

Successful merges:

rustdoc: Improve performance by skipping unneeded intermediate JSON serializations #165495 (rustdoc: Improve performance by skipping unneeded intermediate JSON serializations)
remove stability attributes from intrinsics #165523 (remove stability attributes from intrinsics)
allow configuring rustc_perf's path for out-of-tree uses of rustc_perf #165034 (allow configuring rustc_perf's path for out-of-tree uses of rustc_perf)
use correct span for lifetimes with attributes #165373 (use correct span for lifetimes with attributes)
lint: do not emit unreachable_code on become with diverging callee #165539 (lint: do not emit unreachable_code on become with diverging callee)
rustc_config: Replace Option with a custom enum for --jobs options #165556 (rustc_config: Replace Option with a custom enum for --jobs options)

Warning

This rollup conflicts with pending auto build #165548 and may need to be recreated if the pending build succeeds.

r? @ghost

Create a similar rollup

…imes

…erializations

And use it for linker jobs as well

…callee

…son-serialization, r=lolbinarycat rustdoc: Improve performance by skipping unneeded intermediate JSON serializations Should help with rust-lang#149915. r? ghost

@oli-obk

…i-obk remove stability attributes from intrinsics Intrinsics don't get stabilized and inherit their instability from the context. They should not have their own attributes that would allow accessing them without triggering an "internal feature" warning. r? @oli-obk because a large chunk of these is related to reflection

@JonathanBrouwer

allow configuring rustc_perf's path for out-of-tree uses of rustc_perf r? @JonathanBrouwer Often, when doing benchmarks locally, it's annoying to edit the rustc_perf submodule directly. This explicitly allows configuring an external rustc_perf checkout you can make your own modifications in. > [!NOTE] > I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

…r=JonathanBrouwer use correct span for lifetimes with attributes Fixes rust-lang#105031 Includes the attributes' span, so suggestions don't mistakenly remove them.

…reachable-code, r=JonathanBrouwer lint: do not emit unreachable_code on become with diverging callee  Fixes rust-lang#165536. Exempts `ExprKind::Become(..)` from emitting `unreachable_code` when its inner call expression diverges, while preserving unreachable code warnings for any statements following `become`. ### Changes - Add `| ExprKind::Become(..)` to the diverging child exemption list in `compiler/rustc_hir_typeck/src/expr.rs`. - Add `tests/ui/explicit-tail-calls/become-diverging.rs`.

rustc_config: Replace `Option` with a custom enum for `--jobs` options And use it for linker jobs as well. This is an alternative for rust-lang#163452. Creating different newtypes for different parts of the compiler is excessive, IMO, the meaning of the `Option`/`JobsMode` is the same for frontend, backend, and linker - "avoid overhead in the sequential case". Also this PR eliminates the `Option`s entirely.

JonathanBrouwer · 2026-11-06T20:11:48Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3,test-aarch64-msvc-2

rust-bors · 2026-11-06T20:11:51Z

📌 Commit c772038 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2

rust-bors · 2026-11-06T23:35:18Z

☀️ Try build successful (CI)
Build commit: 12fb241 (12fb241b6867a0833bdbbd847c6a624ab683fdc8)
Base parent: c980177 (c980177d81d16f843a500905ac98c0cf3af1fd8d)

rust-bors · 2026-11-07T00:00:51Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 16m 58s
Pushing c6ac6ea to main...

github-actions · 2026-11-07T00:04:09Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c980177 (parent) -> c6ac6ea (this PR)

Test differences

Show 122 test diffs

Stage 1

[ui] tests/ui/explicit-tail-calls/become-diverging.rs: [missing] -> pass (J1)
[ui] tests/ui/single-use-lifetime/with-attributes.rs: [missing] -> pass (J1)
[ui (polonius)] tests/ui/explicit-tail-calls/become-diverging.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/single-use-lifetime/with-attributes.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/explicit-tail-calls/become-diverging.rs: [missing] -> pass (J0)
[ui] tests/ui/single-use-lifetime/with-attributes.rs: [missing] -> pass (J0)

Additionally, 116 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c6ac6ea53f6c8234fd06ddf0b88d89fe8b46edf5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-aarch64-gnu-llvm-22-2: -> 58m 41s (+inf%)
dist-arm-linux-musl: -> 1h 30m (+inf%)
test-aarch64-gnu: -> 2h 17m (+inf%)
dist-armhf-linux: -> 1h 32m (+inf%)
dist-i586-gnu-i586-i686-musl: -> 29m 30s (+inf%)
dist-i686-mingw: -> 44m (+inf%)
dist-loongarch64-linux: -> 2h 4m (+inf%)
test-aarch64-apple-1: -> 2h 31m (+inf%)
test-x86_64-gnu-gcc-core-tests: -> 16m 24s (+inf%)
test-x86_64-gnu-llvm-22-1: -> 1h 18m (+inf%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-11-07T00:50:06Z

Finished benchmarking commit (c6ac6ea): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.0%, 0.5%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

Results (primary -2.8%, secondary -5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-3.4%, -2.2%]	2
Improvements ✅ (secondary)	-5.1%	[-8.2%, -2.2%]	8
All ❌✅ (primary)	-2.8%	[-3.4%, -2.2%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 484.475s -> 486.121s (0.34%)
Artifact size: 406.31 MiB -> 406.21 MiB (-0.02%)

rust-bors · 2026-11-07T01:05:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#165495	rustdoc: Improve performance by skipping unneeded intermedi…	`fa24798451baf91651edecca0ff8eb09bf24a9db` (link)
#165523	remove stability attributes from intrinsics	`9c1ed4ce9fd34181fb2463babd55a7e88eb42a21` (link)
#165034	allow configuring rustc_perf's path for out-of-tree uses of…	`ebf0d48d0d25a216e8e11fc991cd6ce719456948` (link)
#165373	use correct span for lifetimes with attributes	`08af653964bce388231600c7026177bd805ae672` (link)
#165539	lint: do not emit unreachable_code on become with diverging…	`fcad793d0118dd14363ce105cf90094acedc67c7` (link)
#165556	rustc_config: Replace `Option` with a custom enum for `--jo…	`e17667f7f4e8b7b9d299cccc91d3f163af7c6f4e` (link)

parent commit: c980177d81

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

panstromek · 2026-11-07T06:51:49Z

just include-blob noise

@rustbot label: +perf-regression-triaged

malezjaa and others added 14 commits November 2, 2026 21:16

use correct span for lifetimes with attributes under single_use_lifet…

625d5b2

…imes

rustdoc: Improve performance by skipping unneeded intermediate JSON s…

9e1f871

…erializations

lint: do not emit unreachable_code on become with diverging callee

d3ceb64

allow configuring rustc_perf's path for out-of-tree uses of rustc_perf

cd77d29

remove stability attributes from intrinsics

f338f2a

also remove unnecessary rustc_intrinsic_const_stable_indirect

febe5ea

rustc_config: Replace Option with a custom enum for --jobs options

6381a96

And use it for linker jobs as well

tests: add test for unreachable code following become with diverging …

eea0d6f

…callee

Rollup merge of rust-lang#165495 - GuillaumeGomez:skip-intermediate-j…

34d795e

…son-serialization, r=lolbinarycat rustdoc: Improve performance by skipping unneeded intermediate JSON serializations Should help with rust-lang#149915. r? ghost

Rollup merge of rust-lang#165373 - malezjaa:fix-single-use-lifetime, …

b5a2b58

…r=JonathanBrouwer use correct span for lifetimes with attributes Fixes rust-lang#105031 Includes the attributes' span, so suggestions don't mistakenly remove them.

rust-bors Bot added the rollup A PR which is a rollup label Nov 6, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2026

rust-bors Bot merged commit c6ac6ea into rust-lang:main Nov 7, 2026
16 checks passed

rustbot added this to the 1.101.0 milestone Nov 7, 2026

rustbot added the perf-regression Performance regression. label Nov 7, 2026

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 7, 2026

Navigation Menu

Repository navigation

Rollup of 6 pull requests - #165563

Rollup of 6 pull requests#165563
rust-bors[bot] merged 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-oi3v9Ow

JonathanBrouwer commented Nov 6, 2026

Uh oh!

JonathanBrouwer commented Nov 6, 2026

Uh oh!

rust-bors Bot commented Nov 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Nov 6, 2026

Uh oh!

rust-bors Bot commented Nov 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 7, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 7, 2026

Uh oh!

rust-bors Bot commented Nov 7, 2026

Uh oh!

panstromek commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

JonathanBrouwer commented Nov 6, 2026

Uh oh!

JonathanBrouwer commented Nov 6, 2026

Uh oh!

rust-bors Bot commented Nov 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Nov 6, 2026

Uh oh!

rust-bors Bot commented Nov 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 7, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 7, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Nov 7, 2026

Uh oh!

panstromek commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants