Repository navigation
Correction to assertion regarding the scope of reversible types - #259
Open
JonathanMcCormickJr wants to merge 2 commits into
Open
JonathanMcCormickJr wants to merge 2 commits into
JonathanMcCormickJr wants to merge 2 commits into
Conversation
…s in Spanish and Portugese (limit increased from 99 to 128 characters)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version incorrectly asserts that only strings can be reversed:
This PR corrects this across all 12 current language translations, naming a second type (the array) that can be reversed and using it as a segue into the upcoming pages.
Corrected English:
Corrected Spanish:
The increase in the max-width of the "ok" message highlighting (in
app/editor.rb) was necessary due to the Spanish and Portuguese versions going past 99 characters.