Skip to content

fix(metal): read resolved counter samples with bytes, not mutableBytes #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lastlink wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metal): read resolved counter samples with bytes, not mutableBytes #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plume_metal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <Metal/Metal.hpp>
#include <QuartzCore/QuartzCore.hpp>
#include <CoreFoundation/CoreFoundation.h>
#include <objc/message.h>

#include <algorithm>
#include <mutex>
Expand Down Expand Up @@ -2218,7 +2219,13 @@ namespace plume {
void MetalQueryPool::queryResults() {
MetalAutoreleasePool releasePool;
const NS::Data* data = sampleBuffer->resolveCounterRange(NS::Range(0, results.size()));
std::memcpy(results.data(), data->mutableBytes(), results.size() * sizeof(uint64_t));
if (data == nullptr) {
return;
}

// The resolved data is an immutable NSData, which has no mutableBytes on some GPUs (Intel UHD 630): use bytes.
const void *bytes = reinterpret_cast<const void *(*)(const void *, SEL)>(&objc_msgSend)(data, sel_registerName("bytes"));
std::memcpy(results.data(), bytes, results.size() * sizeof(uint64_t));
}

const uint64_t *MetalQueryPool::getResults() const {
Expand Down