Repository navigation
Conversation
resolveCounterRange returns an immutable NSData. On an Intel UHD 630 (macOS 15.8) it is an NSConcreteData, which has no mutableBytes, so queryResults aborted with an unrecognized selector.
Contributor
|
It seems this was fixed in metal-cpp at some point as the most update to date version has this. We should update our metal-cpp sources first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash on Intel Macs: the Metal backend aborts on the first frames whenever timestamp queries are used.
resolveCounterRange:returns an immutableNSData. On an Intel UHD 630 (macOS 15.8) it is anNSConcreteData, which has nomutableBytes, soMetalQueryPool::queryResults()aborts with an unrecognized selector:A small Metal program on the same Mac confirmed the resolved data is an
NSConcreteDatathat answersbytesbut notmutableBytes.The fix reads it with
bytes(metal-cpp'sNS::Datahas nobytes(), so the selector is sent directly) and returns when there is no data.