Repository navigation
Conversation
…o handle models and use a model's decode/encode structures
…able Replace the AxiomaticModel enum, makeCodec switch, and modelNames map with codecFactories(), so adding a model is one table entry. The round trip test now iterates every registered factory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the name-to-factory table private to axiomatic_codec.cpp. Callers construct a codec by name and list valid names, and an unknown name throws std::invalid_argument with the name in the message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fixture The extended frame listed 3 ID bytes for a 4-byte ID, so the decoder read the data byte as the ID's high byte and the body was one byte short of its declared 21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
davidt315
changed the title
davidt315
added this pull request to stack #22
October 7, 2026 23:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now Axiomatic adapter can take in a model param and handle a specific model's decode/encode functions. This enables the now added support in this PR for ax142100a, while defaulting to the already supported model with no changes. It makes it structurally much easier to add new models as well