Skip to content

Move to the phpbbmodders vendor and update file headers - #35

Merged
bonelifer merged 2 commits into
masterfrom
revendor-phpbbmodders
Oct 6, 2026
Merged

bonelifer merged 2 commits into
masterfrom
revendor-phpbbmodders

Conversation

@bonelifer

@bonelifer bonelifer commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Renames the extension from rmcgirr83/contactadmin to phpbbmodders/contactadmin, following the repository transfer.

Changes

  • Namespaces, service IDs, route names, email template paths, the ACP module and the CI EXTNAME use phpbbmodders.
  • The rmcgirr83.contactadmin.modify_data_and_error event is renamed to phpbbmodders.contactadmin.modify_data_and_error. Stop Forum Spam is the only known listener and is updated in Move to the phpbbmodders vendor and update file headers stopforumspam#65.
  • ext.php moves an existing install to the new name when it is enabled (migration history, ACP module class and auth, old extension record) and refuses to enable while rmcgirr83/contactadmin is still enabled. It requires phpBB 3.3.19 and PHP 7.4 (previously phpBB 3.3).
  • File headers use the phpBB Modders format and keep every original copyright line. composer.json lists phpBB Modders as Extension Developer and Rich McGirr as Past Developer.
  • Removes the donation block from the ACP settings page and .github/FUNDING.yml; both pointed at the previous author's accounts. The phpBB.com version-check entry is unchanged.
  • Adds lint.yml (php -l and composer validate on PHP 7.4 and 8.4).
  • README.MD is renamed to README.md and follows the phpbbmodders layout: features, requirements, installation and upgrade steps from rmcgirr83/contactadmin. composer.json, the README and the repository's About use the same one-line description.

Testing

Claude ran these on a local phpBB 3.3.19 test board:

  • Fresh install smoke test: core pages, the contact form as guest and admin, ACP module, disable → delete data → enable. Clean.
  • Upgrade from rmcgirr83/contactadmin (alongside the Stop Forum Spam upgrade): settings and ACP module kept, no migrations re-run, the contact form loads and the PHP error log is empty.
  • Smoke test re-run after removing the donation block: the ACP settings page renders cleanly.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

🤖 Generated with Claude Code

Renames the extension from rmcgirr83/contactadmin to phpbbmodders/contactadmin, including its route, service and event names. ext.php moves an existing install's migration history, ACP module and extension record to the new name on enable, refuses to enable while the old copy is still enabled, and requires phpBB 3.3.19 and PHP 7.4.

File headers use the phpBB Modders format and keep the original copyright lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The donation block in the ACP settings page and .github/FUNDING.yml pointed at the previous author's accounts. README.MD is renamed to README.md and follows the phpbbmodders layout; composer.json uses the same one-line description as the README and repository.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer bonelifer mentioned this pull request Oct 6, 2026
@bonelifer
bonelifer merged commit 8d3f745 into master Oct 6, 2026
3 checks passed
@bonelifer
bonelifer deleted the revendor-phpbbmodders branch October 6, 2026 20:51
@bonelifer bonelifer mentioned this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant