Repository navigation
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bc2acfa to
2d51865
Compare
… already exist (openedx#38973) (cherry picked from commit 07f0986)
(cherry picked from commit b13ef66)
(cherry picked from commit 7510e57)
…signments (openedx#38984) (cherry picked from commit 05fa2e1)
…org_for_user (openedx#38980) (cherry picked from commit 8f802e8)
…ourse (openedx#39055) (cherry picked from commit 9a25796)
openedx#39013) (cherry picked from commit f3a87b1)
…penedx#39112) (cherry picked from commit ecb9f5e)
…penedx#39050) (cherry picked from commit b91a89e)
(cherry picked from commit d9d3b7e)
(cherry picked from commit 294f05f)
…edx#39010) (cherry picked from commit 4fb000f)
2d51865 to
a717165
Compare
Closes: openedx/openedx-authz#513
Description
Backport to
release/verawoodof the RBAC (openedx-authz) bug fixes already merged intomaster, as tracked in openedx/openedx-authz#513. They fix wrongful 403s in Studio, crashes with platform-wide (glob) role assignments, and inconsistent permission gates.Commits
openedx-authz1.21.0 → 1.23.0view_*permission PRs (1.23.0).requirements/*.txthunks were dropped because the bump is in commit 1.RoleCachelegacy compat layer ignores platform-wide glob role assignmentsget_orgs_for_user/has_org_for_userblock.py,preview.py, tests and template without it).can_tag_object's course check authorization-service awarecontent_tagging/rest_api/v1/views.py, because Verawood pinsopenedx-core==1.0.3and its view differs from master. Resolved by keeping Verawood's code, removingObjectTagOrgView.ensure_user_has_can_tag_object_permissions, and dropping the now-unusedCOURSES_MANAGE_TAGSimport. The parent method inopenedx-core1.0.3 resolves throughhas_perm("oel_tagging.can_tag_object"), as the PR assumes.edit/manage_tagspermissionscontentstore/utils.py, because master migratedENABLE_COURSEWARE_INDEXoffFEATURES-as-dict. Resolved by keepingsettings.FEATURES.get('ENABLE_COURSEWARE_INDEX', False)plus the newuser_can_reindex_course(...)check.contentstore/views/course.pyandcontentstore/views/tests/test_group_configurations.py, because master dropped the legacy Group Configurations page (49c2f556ac) while Verawood still has it. Resolved by keeping Verawood's legacytext/htmlbranch ingroup_configurations_list_handler(including theredirectandrender_to_response) and applying only the PR's read/write permission changes. In the tests, the imports were merged: Verawood'soverride_waffle_flagandtoggleswere kept, andCOURSE_AUDITORandCOURSE_EDITORwere added. Requires authz 1.23.0.Not included yet
ProctoredExamSettingsView#39196UnboundLocalErrorinBulkRoleCache.prefetch(authz compat roles loop) openedx-authz#514 (Without PR yet)