Skip to content

build(deps): update pnpm and CodeQL action - #99

Merged
steipete merged 1 commit into
mainfrom
build/round8-dependency-updates
Oct 7, 2026
Merged

steipete merged 1 commit into
mainfrom
build/round8-dependency-updates

Conversation

@steipete

@steipete steipete commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Update the pinned developer package manager from pnpm 12.5.1 to 12.9.1 and regenerate its lockfile. Update both CodeQL Action steps from 4.38.1 to the verified 4.38.2 commit; this patch advances the default CodeQL bundle to 2.27.1.

Validation: pnpm 12.9.1 frozen-lockfile installation, pnpm docs:site, workflow lint, and git diff --check pass. Independent Codex autoreview found no actionable P0–P2 findings. Full macOS CI and all three CodeQL language jobs run on the PR.

These are development and analysis dependency updates; remindctl stays at 0.3.8 with the existing runtime requirements.

Pin pnpm 12.9.1 with its regenerated lockfile and CodeQL Action 4.38.2, whose default analysis bundle advances to 2.27.1. Frozen-lockfile install, documentation build, workflow lint, and independent review pass.
@clawsweeper

clawsweeper Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 7, 2026
@clawsweeper

clawsweeper Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed October 7, 2026, 7:50 AM ET / 11:50 UTC.

ClawSweeper review

What this changes

The PR updates the developer package manager to pnpm 12.9.1, regenerates its lockfile, and updates both CodeQL analysis steps to version 4.38.2.

Merge readiness

✅ Ready for maintainer review

Keep open: main still uses the older tooling pins, and this focused update has no actionable correctness or security finding. The collaborator-authored PR requires no additional review remediation.

Priority: P3
Reviewed head: 4d38eff261139ed09efdf9574a53f19f26f50804

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, consistent dependency refresh with verified upstream identities and no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: The collaborator-authored tooling update is exempt from external-contributor runtime proof; reported installation validation and successful analysis jobs supplement the source review. No application storage format or migration changes.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The collaborator-authored tooling update is exempt from external-contributor runtime proof; reported installation validation and successful analysis jobs supplement the source review. No application storage format or migration changes.
Evidence reviewed 6 items Complete introduced change: Read the entire pinned delta: only the two CodeQL action pins, packageManager version, and matching pnpm package versions and integrity values change. Workflow permissions, build commands, runtime source, and application version remain unchanged.
Still necessary on main: The pinned main package.json uses pnpm 12.5.1; its CodeQL workflow uses v4.38.1. The requested versions are therefore distinct work, rather than an already implemented update.
Verified upstream action pin: The annotated v4.38.2 tag resolves to the exact introduced commit. Its published release notes identify the default CodeQL bundle update to 2.27.1: https://github.com/github/codeql-action/releases/tag/v4.38.2.
Findings None None.
Security None None.

How this fits together

pnpm runs remindctl's developer scripts, while CodeQL analyzes its Swift, JavaScript, and workflow source in GitHub Actions. These tooling pins affect source builds and analysis rather than the installed Reminders CLI.

flowchart LR
  A[Developer checkout] --> B[Pinned pnpm]
  B --> C[Build and developer scripts]
  D[GitHub pull request] --> E[CodeQL analysis]
  F[Swift and workflow source] --> E
  E --> G[Security analysis results]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Package integrity checks 15 of 15 updated integrity values verified Every regenerated package checksum matches the published npm metadata.

Technical review

Best possible solution:

Maintain consistent package-manager and lockfile pins and immutable upstream CodeQL action references through the existing build and analysis workflows.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this dependency refresh reports no runtime bug; source inspection confirms the exact version changes.

Is this the best way to solve the issue?

Yes: updating the existing pins and matching lockfile is the narrowest consistent approach, with no duplicate tooling path or runtime change.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against cdd7a06b8527.

Labels

Label changes:

  • add P3: This is a bounded developer-tooling refresh with no identified urgent user-facing defect.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling update is exempt from external-contributor runtime proof; reported installation validation and successful analysis jobs supplement the source review. No application storage format or migration changes.

Label justifications:

  • P3: This is a bounded developer-tooling refresh with no identified urgent user-facing defect.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling update is exempt from external-contributor runtime proof; reported installation validation and successful analysis jobs supplement the source review. No application storage format or migration changes.

Evidence

What I checked:

  • Complete introduced change: Read the entire pinned delta: only the two CodeQL action pins, packageManager version, and matching pnpm package versions and integrity values change. Workflow permissions, build commands, runtime source, and application version remain unchanged. (4d38eff26113)
  • Still necessary on main: The pinned main package.json uses pnpm 12.5.1; its CodeQL workflow uses v4.38.1. The requested versions are therefore distinct work, rather than an already implemented update. (package.json:20, cdd7a06b8527)
  • Verified upstream action pin: The annotated v4.38.2 tag resolves to the exact introduced commit. Its published release notes identify the default CodeQL bundle update to 2.27.1: https://github.com/github/codeql-action/releases/tag/v4.38.2. (2892aa5e19bb)
  • Registry integrity and requirements: An in-memory Python registry check verified all 15 introduced package integrity values against npm metadata. Registry metadata identifies pnpm/pnpm as the source repository. pnpm 12.5.1 and 12.9.1 have identical declared Node engines and lifecycle scripts.
  • Prior merged tooling ownership: GitHub verifies build(deps): update docs tooling and CodeQL #94 as merged, authored by steipete. Its commit patch updates these same tooling pins to the versions currently on main. Local deeper history and blame encountered unavailable historical blobs; the GitHub commit patch supplied the relevant prior-change evidence. (.github/workflows/codeql.yml:49, 79ebce8c1546)
  • Validation and proof scope: The complete supplied PR body reports a pnpm 12.9.1 frozen-lockfile installation, documentation build, workflow lint, and diff check. Supplied checks show successful Actions and JavaScript CodeQL analysis, with Swift analysis and macOS build still running. Collaborator authorship exempts this PR from the external-contributor proof gate; no authority or stored-data contract changes trigger an additional gate. (4d38eff26113)

Likely related people:

  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit a671703 into main Oct 7, 2026
10 checks passed
@steipete
steipete deleted the build/round8-dependency-updates branch October 7, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant