Skip to content

build(deps): update docs tooling and CodeQL - #94

Merged
steipete merged 1 commit into
mainfrom
build/current-tooling
Sep 22, 2026
Merged

steipete merged 1 commit into
mainfrom
build/current-tooling

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Update the pinned docs runtime to Node.js 26.10.0, the package manager to pnpm 12.5.1, and CodeQL to v4.38.1 at its verified commit. Regenerate the lockfile with pnpm 12.5.1. The macOS CLI deployment target is unchanged.

Validation: actionlint passes, and independent Codex autoreview found no actionable P0–P2 findings. Docs are built on AWS Crabbox with the pinned Node version; full macOS validation remains in CI.

@clawsweeper

clawsweeper Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Sep 22, 2026
@clawsweeper

clawsweeper Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed September 22, 2026, 8:08 AM ET / 12:08 UTC.

ClawSweeper review

What this changes

Updates the docs runtime to Node.js 26.10.0, pnpm to 12.5.1 with matching lockfile entries, and both CodeQL action pins to v4.38.1.

Merge readiness

✅ Ready for maintainer review

Keep open: this focused tooling update remains absent from main, and no actionable correctness or security defect was found. The collaborator-authored PR is also protected from automatic closure.

Priority: P3
Reviewed head: 0035de1d2d4c5aab4f0c25a29bdb3a09a9b5d1f4

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, internally consistent dependency update with verified upstream pins and no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: The collaborator-authored tooling PR is exempt from contributor runtime proof. Its reported Crabbox docs build and successful docs/CodeQL checks support the affected paths; no application storage contract changes.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The collaborator-authored tooling PR is exempt from contributor runtime proof. Its reported Crabbox docs build and successful docs/CodeQL checks support the affected paths; no application storage contract changes.
Evidence reviewed 7 items Complete introduced change: The pinned base-to-head diff changes four tooling files only; scripts, workflow permissions, application source, and the macOS deployment target remain unchanged.
Main and release still use previous pins: The inspected main blobs retain Node 26.8.2, pnpm 12.4.1, and CodeQL v4.38.0. Release v0.3.7 also retains Node 26.8.2 and pnpm 12.4.1; the requested update is not already implemented.
CodeQL pin verified upstream: The annotated v4.38.1 tag resolves to the exact commit used by both changed action references. The published release describes experimental per-language bundle support: https://github.com/github/codeql-action/releases/tag/v4.38.1.
Findings None None.
Security None None.

How this fits together

Node builds remindctl’s documentation site, pnpm runs developer commands, and CodeQL scans the repository in GitHub Actions. These tooling choices affect development and CI without changing the macOS Reminders implementation.

flowchart LR
  A[Documentation sources] --> B[Pinned Node runtime]
  B --> C[Documentation site]
  D[Developer commands] --> E[Pinned pnpm]
  E --> F[Swift build and checks]
  G[Repository source] --> H[Pinned CodeQL scans]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

None.

Technical review

Best possible solution:

Maintain one consistent set of published tooling pins while retaining the existing scripts, CI permissions, and macOS support contract.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR updates tooling versions rather than reporting broken product behavior.

Is this the best way to solve the issue?

Yes: updating the existing pins and matching lockfile is a narrow, consistent approach; upstream metadata verifies the selected versions and integrity values.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 2a1da5fab273.

Labels

Label changes:

  • add P3: Routine tooling maintenance with no demonstrated user-facing regression or application behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling PR is exempt from contributor runtime proof. Its reported Crabbox docs build and successful docs/CodeQL checks support the affected paths; no application storage contract changes.

Label justifications:

  • P3: Routine tooling maintenance with no demonstrated user-facing regression or application behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling PR is exempt from contributor runtime proof. Its reported Crabbox docs build and successful docs/CodeQL checks support the affected paths; no application storage contract changes.

Evidence

What I checked:

  • Complete introduced change: The pinned base-to-head diff changes four tooling files only; scripts, workflow permissions, application source, and the macOS deployment target remain unchanged. (package.json:20, 0035de1d2d4c)
  • Main and release still use previous pins: The inspected main blobs retain Node 26.8.2, pnpm 12.4.1, and CodeQL v4.38.0. Release v0.3.7 also retains Node 26.8.2 and pnpm 12.4.1; the requested update is not already implemented. (.node-version:1, f4326de7fa16)
  • CodeQL pin verified upstream: The annotated v4.38.1 tag resolves to the exact commit used by both changed action references. The published release describes experimental per-language bundle support: https://github.com/github/codeql-action/releases/tag/v4.38.1. (1c5b675653bb)
  • Package integrity and compatibility metadata: Read-only npm registry checks matched all 15 changed package integrity values, including pnpm and its 14 platform executables. Registry metadata identifies pnpm/pnpm as their repository. Comparing 12.4.1 and 12.5.1 found unchanged lifecycle scripts, Node engine requirements, and optional-dependency names. Metadata source: https://registry.npmjs.org/pnpm/12.5.1.
  • Node release availability: The official https://nodejs.org/dist/index.json lists v26.10.0, dated 2026-09-21, with Linux and macOS artifacts. This verifies availability of the new docs runtime.
  • Production consumers and validation scope: CI and Pages both read .node-version and run make docs-site, which invokes scripts/build-docs-site.mjs. The supplied checks show successful docs and Actions/JavaScript CodeQL jobs, with Swift checks still running. The body reports a Crabbox docs build and actionlint success; these claims were not independently rerun. (.github/workflows/ci.yml:23, 0035de1d2d4c)

Likely related people:

  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit 79ebce8 into main Sep 22, 2026
10 checks passed
@vincentkoc
vincentkoc deleted the build/current-tooling branch September 25, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant